46853[TASK] Move domain redirectTo functionality to TSFC
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 4
-
Andreas Wolf uploaded patch set 1 02/23/16, 19:24
-
Georg Ringer commented on patch set 1 CR -1 02/24/16, 05:02
this is a breaking change because calling DomainRepository::getDomainStartPage() does not do a redirect now anymore. this needs a rst!issue missing. please mark a commit with [WIP] if not ready. -
Benni Mack commented on patch set 1 03/31/16, 13:49
getDomainStartPage() is wrong now, as it returns the Domain record + the page ID. So the naming of that method now is completely wrong. How about a new method getDomainRecord() inide pagerepository to do that and we mark the other one as deprecated? -
Benni Mack abandoned the change 03/28/17, 09:10
He y Andreas, I abandoned this patch for now, as we're probably will go in a different direction for solving this issue.