Review main Merged

46880[BUGFIX] Convert colPos in backend layout wizard to number

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 02/25/16, 16:35

Commit message

The method `setColumn` in the backend layout wizard sanitizes the
value by wrapping it into a <p> tag and fetching its text which strips
off any HTML. This returns a string.

However, the code later checks after performing a save action whether
the value is a number. The value gets converted to a number in
`setColumn` to recover the functionality.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
  • Verified V +2
    • Morton Jonuschat +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Andreas Kienast uploaded patch set 1 02/24/16, 18:13

  2. Andreas Kienast wrote 02/24/16, 18:15

    Patch set 2: Commit message was updated.
  3. Wouter Wolters commented on patch set 2 CR +1 V +1 02/24/16, 18:34

    watch out for browser caches!
  4. Morton Jonuschat voted on patch set 2 CR +2 V +2 02/25/16, 16:35

  5. Gerrit merged patch set 2 02/25/16, 16:35