Review main Merged

46881[BUGFIX] Do not escape output of Nl2Bbr ViewHelper

Michael Oehlhof CR +2 V +2 Easy +5 −0 updated 03/02/16, 04:56

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Claus Due +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 11

  1. Michael Oehlhof uploaded patch set 1 02/24/16, 19:41

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 02/24/16, 19:47

  3. Markus Klein commented on patch set 1 CR -1 02/24/16, 19:52

    IMO this is a bug in the nl2br VH! Why is its output run through hsc??
  4. Christian Kuhn voted on patch set 1 CR -1 02/26/16, 17:52

  5. Andreas Kienast voted on patch set 1 CR 0 V 0 02/26/16, 18:43

  6. Claus Due commented on patch set 1 02/29/16, 13:34

    Should be solved by adding "protected $escapeChildren = true;" and "protected $escapeOutput = false;" on the Nl2brViewHelper (and possibly others which should behave the same way).
  7. Wouter Wolters uploaded patch set 2 03/01/16, 18:06

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 03/01/16, 18:06

  9. Claus Due voted on patch set 2 CR +1 03/01/16, 23:19

  10. Georg Ringer voted on patch set 2 CR +2 V +2 03/02/16, 04:56

  11. Gerrit merged patch set 2 03/02/16, 04:56