Review main Abandoned

46894[BUGFIX] Allow service chaining for SaltedPasswordService authUser

Robert Schulze CR 0 V 0 Easy +1 −1 updated 03/07/16, 13:11

Commit message

In general it should be possible to apply service chaining for the subtypes
authUserFE & authUserBE. This commit fixes a bug within the implementation
of SaltedPasswordService authUser. That bug was responsible for not allowing
service chaining at all.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Robert Schulze uploaded patch set 1 02/25/16, 14:17

  2. Jonas Götze voted on patch set 1 CR +1 03/06/16, 10:09

  3. Jonas Götze voted on patch set 1 V +1 03/06/16, 11:34

  4. Daniel Goerz voted on patch set 1 CR +1 03/06/16, 11:45

  5. Xavier Perseguers commented on patch set 1 CR +1 03/07/16, 12:39

    SaltedPasswordService.php:186

    could be cast to bool instead of int?
  6. Nicole Hummel commented on patch set 1 CR -2 03/07/16, 12:45

    SaltedPasswordService.php:186

    This can be simply dropped. Will push a new patch set
  7. Nicole Hummel commented on patch set 1 03/07/16, 12:56

    This patch re-introduces the possibility of authentication bypassing and we cannot merge it. If a salted hash is used this service has to make sure there isn't another service in the chain if authentication was wrong. you have to change your service to be tried before the saltedpassword ones
  8. Nicole Hummel abandoned the change 03/07/16, 13:11