46894[BUGFIX] Allow service chaining for SaltedPasswordService authUser
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 8
-
Robert Schulze uploaded patch set 1 02/25/16, 14:17
-
Jonas Götze voted on patch set 1 CR +1 03/06/16, 10:09
-
Jonas Götze voted on patch set 1 V +1 03/06/16, 11:34
-
Daniel Goerz voted on patch set 1 CR +1 03/06/16, 11:45
-
Xavier Perseguers commented on patch set 1 CR +1 03/07/16, 12:39
-
Nicole Hummel commented on patch set 1 CR -2 03/07/16, 12:45
SaltedPasswordService.php:186This can be simply dropped. Will push a new patch set -
Nicole Hummel commented on patch set 1 03/07/16, 12:56
This patch re-introduces the possibility of authentication bypassing and we cannot merge it. If a salted hash is used this service has to make sure there isn't another service in the chain if authentication was wrong. you have to change your service to be tried before the saltedpassword ones -
Nicole Hummel abandoned the change 03/07/16, 13:11
SaltedPasswordService.php:186