Review main Merged

46904[TASK] Move install update flags to system registry

Mathias Brodala CR +2 V +2 Normal +109 −10 updated 03/10/16, 13:36

Commit message

This moves the install update (aka "wizards") flags from
LocalConfiguration.php to the system registry and thus
into the database.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benni Mack +1

Issues 1

Files 6

Review log 17

  1. Mathias Brodala uploaded patch set 1 02/26/16, 09:39

  2. Mathias Brodala uploaded patch set 2 02/26/16, 11:20

  3. Benni Mack commented on patch set 2 02/29/16, 06:36

    AbstractUpdate.php:202

    how about we call this field "InstallToolUpdate" in the registry?
  4. Mathias Brodala commented on patch set 2 02/29/16, 10:19

    AbstractUpdate.php:202 Reply

    I'm fine with any name as long as we agree on using it for the time being. ;-)
  5. Mathias Brodala uploaded patch set 3 02/29/16, 10:31

  6. Mathias Brodala commented on patch set 3 02/29/16, 10:31

    Changed registry namespace to "installUpdate" (EXT:install + "update"), also rebased to maste.
  7. Mathias Brodala uploaded patch set 4 03/01/16, 14:49

  8. Mathias Brodala commented on patch set 4 03/01/16, 14:49

    Rebased to master.
  9. Benni Mack commented on patch set 4 03/02/16, 05:43

    awesome. could you please add a Important RST (as it's a cool and important change) so people know about it?
  10. Wouter Wolters commented on patch set 4 03/02/16, 07:38

    What about $obsoleteLocalConfigurationSettings in SilentConfigurationUpgradeService ?

    AbstractUpdate.php:219

    space missing before the dot.
  11. Mathias Brodala commented on patch set 4 03/02/16, 09:24

    > (1 comment) > > What about $obsoleteLocalConfigurationSettings in SilentConfigurationUpgradeService > ? That's not an option unfortunately since that would silently drop "INSTALL/wizardDone" where we need to migrate the existing values instead.

    AbstractUpdate.php:219 Reply

    Done
  12. Mathias Brodala uploaded patch set 5 03/02/16, 09:24

  13. Benni Mack voted on patch set 5 CR +1 V +1 03/03/16, 15:46

  14. Anja Leichsenring voted on patch set 5 CR +2 V +2 03/03/16, 16:18

  15. Gerrit merged patch set 5 03/03/16, 16:18

  16. Helmut Hummel commented on patch set 6 03/10/16, 13:07

    This change introduces an additional dependency to the database during installation. I haven't checked manual installation yet, but at least during cli install, there is a warning emmitted, which causes the installation to fail. What are the immediate benefits of having this info in the database compared to the localconfiguration file? are these benefits really worth the additional potential issues we need to deal with now? Will check now if manual install also causes the warning I'm seeing on cli

    DefaultConfiguration.php:114

    at this point the database might not be properly set up yet
  17. Helmut Hummel commented on patch set 6 03/10/16, 13:36