Review main Abandoned

46929[BUGFIX] Add type check before exploding to methods in BackendUtility

Sebastian Fischer CR 0 V 0 Easy +10 −2 updated 03/28/17, 14:43

Commit message

This bugfix adds is_array checks to getLabelsFromItemsList and
getProcessedValue to ensure that only strings get exploded

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Sebastian Fischer uploaded patch set 1 02/27/16, 13:01

  2. Andreas Kienast commented on patch set 1 CR +1 V +1 02/27/16, 13:10

    Looks obvious to me
  3. Frank Nägler commented on patch set 1 CR -1 02/29/16, 08:52

    BackendUtility.php:1783

    the argument $keyList is defined as string, the fix must be in place where this method is called with an array.

    BackendUtility.php:2090

    the same here, the argument is defined as a string.
  4. Christian Kuhn commented on patch set 1 03/02/16, 11:20

    give me some time to dig into this, please. main issue is probably that FormEngine hands this over as array, this could also be changed for this specific dependency on the dataProvider end, but i'd like to sort out the details here to see what is the best solution.
  5. Andreas Kienast wrote 03/03/16, 15:33

    Removed the following votes: * Code-Review+1 by Andreas Fernandez <typo3@scripting-base.de> * Verified+1 by Andreas Fernandez <typo3@scripting-base.de>
  6. Wouter Wolters commented on patch set 1 06/07/16, 21:07

    ping
  7. Christian Kuhn commented on patch set 1 06/08/16, 07:50

    BackendUtility.php:1783 Reply

    +1. imho the patch is bogus. wrong usages should be fixed instead.
  8. Christian Kuhn voted on patch set 1 CR -1 06/08/16, 07:50

  9. Christian Kuhn commented on patch set 1 06/08/16, 07:55

    BackendUtility.php:1783 Reply

    ... actually not entirely sure how to deal with that here. sebastian, could you give us some more insights an how exactly you triggered this problem?
  10. Benni Mack abandoned the change 03/28/17, 14:43

    No activity, plus: Mis-usage of a defined API call should be taken care of on the implementers side.
  11. Benni Mack commented on patch set 1 03/28/17, 14:43

    @Lolli - please see the ticket on forge to see if the use-case still applies after FormEngine refactoring.