Review main Merged

46933[FEATURE] Trigger event after modals dismiss

Andreas Kienast CR +2 V +2 Easy +25 −0 updated 03/06/16, 00:01

Commit message

A new event ``modal-destroyed`` is triggered after modals dismissed.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jan Helke +1
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 2

Review log 13

  1. Andreas Kienast uploaded patch set 1 02/27/16, 21:18

  2. Jan Helke voted on patch set 1 CR +1 V +1 02/28/16, 07:28

  3. Frans Saris commented on patch set 1 02/28/16, 10:23

    Why not just use the bootstrap events? If there is a use-case for this maybe add this to commit message/feature rst.
  4. Andreas Kienast commented on patch set 1 02/28/16, 10:50

    We do not want to use the bootstrap events on the outside in case we change the modal library sometime.
  5. Georg Ringer voted on patch set 1 CR +1 V +1 02/28/16, 20:01

  6. Frank Nägler commented on patch set 1 CR -1 02/29/16, 08:41

    Modal.js:231

    on line 310 we trigger: Modal.currentModal.trigger('modal-dismiss'); We should think about the triggered events and maybe use better names, specially for new events? e.b. modal-after-dismissed ?
  7. Andreas Kienast wrote 02/29/16, 15:24

    Patch set 2: Published edit on patch set 1.
  8. Frank Nägler commented on patch set 2 02/29/16, 16:30

    Modal.js:231

    what do you think about modal-before-destroyed AND modal-after-destroyed after on the last line of this method?
  9. Andreas Kienast commented on patch set 2 02/29/16, 19:03

    Modal.js:231 Reply

    modal-after-destroyed won't work for `currentModal` as it is already remove before.
  10. Benni Mack commented on patch set 2 CR +1 03/05/16, 21:14

    I consider this a no-brainer (as we need this feature with the new workspaces patch and it won't break anything), but also non-testable. I will merge this soon if no one objects.
  11. Jan Helke voted on patch set 2 CR +1 03/05/16, 21:17

  12. Benni Mack voted on patch set 2 CR +2 V +2 03/06/16, 00:01

  13. Gerrit merged patch set 2 03/06/16, 00:01