46933[FEATURE] Trigger event after modals dismiss
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Jan Helke +1
-
Verified V +2
- Benni Mack +2
Issues 1
Files 2
Review log 13
-
Andreas Kienast uploaded patch set 1 02/27/16, 21:18
-
Jan Helke voted on patch set 1 CR +1 V +1 02/28/16, 07:28
-
Frans Saris commented on patch set 1 02/28/16, 10:23
Why not just use the bootstrap events? If there is a use-case for this maybe add this to commit message/feature rst. -
Andreas Kienast commented on patch set 1 02/28/16, 10:50
We do not want to use the bootstrap events on the outside in case we change the modal library sometime. -
Georg Ringer voted on patch set 1 CR +1 V +1 02/28/16, 20:01
-
Frank Nägler commented on patch set 1 CR -1 02/29/16, 08:41
Modal.js:231on line 310 we trigger: Modal.currentModal.trigger('modal-dismiss'); We should think about the triggered events and maybe use better names, specially for new events? e.b. modal-after-dismissed ? -
Andreas Kienast wrote 02/29/16, 15:24
Patch set 2: Published edit on patch set 1. -
Frank Nägler commented on patch set 2 02/29/16, 16:30
Modal.js:231what do you think about modal-before-destroyed AND modal-after-destroyed after on the last line of this method? -
Andreas Kienast commented on patch set 2 02/29/16, 19:03
Modal.js:231Replymodal-after-destroyed won't work for `currentModal` as it is already remove before. -
Benni Mack commented on patch set 2 CR +1 03/05/16, 21:14
I consider this a no-brainer (as we need this feature with the new workspaces patch and it won't break anything), but also non-testable. I will merge this soon if no one objects. -
Jan Helke voted on patch set 2 CR +1 03/05/16, 21:17
-
Benni Mack voted on patch set 2 CR +2 V +2 03/06/16, 00:01
-
Gerrit merged patch set 2 03/06/16, 00:01