Review main Merged Breaking

46978[!!!][TASK] Remove charset conversion in AbstractPlugin

Benni Mack CR +2 V +2 Normal +30 −21 updated 03/03/16, 14:17

Commit message

When overriding labels via TypoScript, e.g.
plugin.tx_felogin_pi1._LOCAL_LANG.de.username = Yeah Ümlauts
then the abstract plugin does a conversion of the string
from UTF-8 to renderCharset. However, as all values from
TypoScript are considered UTF-8 anyway, the checks
can be removed.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Michiel Roos +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Michiel Roos +1

Issues 1

Files 2

Review log 14

  1. Benni Mack uploaded patch set 1 03/01/16, 07:12

  2. Georg Ringer voted on patch set 1 CR +1 V +1 03/01/16, 09:23

  3. Oliver Klee voted on patch set 1 CR +1 03/01/16, 09:28

  4. Michael Oehlhof voted on patch set 1 CR +1 03/01/16, 10:05

  5. Christian Kuhn commented on patch set 1 03/01/16, 14:52

    AbstractPlugin.php:110

    hmm, since we're doing relatively little changes to pibase, and even if this property is probably rather internal and hopefully not used too much in the wild, we maybe still should add a breaking.rst file for this property to hint people about it.
  6. Benni Mack commented on patch set 1 CR -1 03/01/16, 14:58

    Agreed, will add a breaking RST
  7. Benni Mack uploaded patch set 2 03/02/16, 06:10

  8. Oliver Klee voted on patch set 2 CR +1 03/02/16, 08:43

  9. Michiel Roos commented on patch set 2 CR +1 03/03/16, 10:41

    Any tips on how to actually verify this patch?
  10. Benni Mack commented on patch set 2 03/03/16, 10:50

    I installed EXT:felogin and did an override of the labels (see the commit message) via TypoScript, then changed the TS to config.metaCharset = iso-8859-15 and checked if the output still works.
  11. Michiel Roos voted on patch set 2 V +1 03/03/16, 11:44

  12. Georg Ringer voted on patch set 2 CR +1 V +1 03/03/16, 14:16

  13. Benni Mack voted on patch set 2 CR +2 V +2 03/03/16, 14:17

  14. Gerrit merged patch set 2 03/03/16, 14:17