46978[!!!][TASK] Remove charset conversion in AbstractPlugin
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Michiel Roos +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Michiel Roos +1
Issues 1
Files 2
Review log 14
-
Benni Mack uploaded patch set 1 03/01/16, 07:12
-
Georg Ringer voted on patch set 1 CR +1 V +1 03/01/16, 09:23
-
Oliver Klee voted on patch set 1 CR +1 03/01/16, 09:28
-
Michael Oehlhof voted on patch set 1 CR +1 03/01/16, 10:05
-
Christian Kuhn commented on patch set 1 03/01/16, 14:52
-
Benni Mack commented on patch set 1 CR -1 03/01/16, 14:58
Agreed, will add a breaking RST -
Benni Mack uploaded patch set 2 03/02/16, 06:10
-
Oliver Klee voted on patch set 2 CR +1 03/02/16, 08:43
-
Michiel Roos commented on patch set 2 CR +1 03/03/16, 10:41
Any tips on how to actually verify this patch? -
Benni Mack commented on patch set 2 03/03/16, 10:50
I installed EXT:felogin and did an override of the labels (see the commit message) via TypoScript, then changed the TS to config.metaCharset = iso-8859-15 and checked if the output still works. -
Michiel Roos voted on patch set 2 V +1 03/03/16, 11:44
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/03/16, 14:16
-
Benni Mack voted on patch set 2 CR +2 V +2 03/03/16, 14:17
-
Gerrit merged patch set 2 03/03/16, 14:17
AbstractPlugin.php:110