Review main Merged Breaking

46979[!!!][TASK] Remove renderCharset option

Benni Mack CR +2 V +2 Hard +378 −407 updated 03/03/16, 15:14

Commit message

The renderCharset TypoScript option is used for internal
parsing of data coming from various sources (TypoScript,
Language Labels, Database, POST variables). As TYPO3
can only operate with UTF-8 in language files for the backend, and expects a UTF-8 compliant database,
the option is now always set to "utf-8" and cannot be changed.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Maier +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Maier +1

Issues 1

Files 23

Show 3 more files

Review log 8

  1. Benni Mack uploaded patch set 1 03/01/16, 07:49

  2. Benni Mack uploaded patch set 2 03/02/16, 06:58

  3. Jigal van Hemert commented on patch set 2 CR +1 03/03/16, 11:55

    Small changelog text modification wanted.

    Breaking-73794-RenderCharsetOptionRemoved.rst:18

    Non UTF-8 databases are no problem as we're already using utf-8 for the connection charset and the DBMS will do the conversion to UTF-8 for us.
  4. Benni Mack wrote 03/03/16, 12:11

    Patch set 3: Published edit on patch set 2.
  5. Anja Leichsenring voted on patch set 3 CR +1 V +1 03/03/16, 15:07

  6. Daniel Maier voted on patch set 3 CR +1 V +1 03/03/16, 15:14

  7. Anja Leichsenring voted on patch set 3 CR +2 V +2 03/03/16, 15:14

  8. Gerrit merged patch set 3 03/03/16, 15:14