Review main Merged

46985[BUGFIX] Make ClickEnlargeViewHelper output data again

Wouter Wolters CR +2 V +2 Easy +8 −1 updated 03/04/16, 21:48

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • Gianluigi Martino +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters uploaded patch set 1 03/01/16, 19:05

  2. Gianluigi Martino voted on patch set 1 V +1 03/03/16, 14:43

  3. Tymoteusz Motylewski commented on patch set 1 03/03/16, 15:55

    how to test it?
  4. Wouter Wolters commented on patch set 1 03/03/16, 15:58

    this viewhelper is used when the lightbow option is turned on. Use the constant editor :) Create an text with media element with 2 images and enable click enlarge
  5. Riccardo De Contardi commented on patch set 1 V +1 03/03/16, 22:43

    verified with 1 image, click-enlarge activated. The rendered code is: <a href="/fileadmin/_processed_/csm_cdz_1_16efa2b817.jpg" class="lightbox" rel="lightbox[34]"><img alt="alt text" src="/fileadmin/_processed_/csm_cdz_1_70950ffc5b.jpg" width="100" height="56"></a>
  6. Daniel Goerz voted on patch set 1 CR +1 V +1 03/04/16, 20:59

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/16, 21:46

  8. Gerrit merged patch set 1 03/04/16, 21:48