Review main Merged Breaking

47004[!!!][TASK] Remove unused csConv parameters

Benni Mack CR +2 V +2 Normal +54 −26 updated 03/04/16, 21:39

Commit message

There are several additional parameters that are not used
anymore.

CharsetConverter->entities_to_utf8() - now always
CharsetConverter->utf8_to_numberarray() now always
converts entities, and real UTF-8 characters are returned

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Daniel Maier +1
  • Verified V +2
    • Benjamin Kott +2
    • Daniel Maier +1

Issues 1

Files 6

Review log 7

  1. Benni Mack uploaded patch set 1 03/03/16, 11:07

  2. Benni Mack uploaded patch set 2 03/03/16, 16:58

  3. Wouter Wolters wrote 03/03/16, 18:29

    Patch set 3: Commit message was updated.
  4. Daniel Maier wrote 03/04/16, 21:21

    Patch set 4: Published edit on patch set 3.
  5. Daniel Maier voted on patch set 4 CR +1 V +1 03/04/16, 21:30

  6. Benjamin Kott voted on patch set 4 CR +2 V +2 03/04/16, 21:39

  7. Gerrit merged patch set 4 03/04/16, 21:39