Review main Merged

47006[TAKS] Add json as composer dependency

Tymoteusz Motylewski CR +2 V +2 Easy +6 −3 updated 03/04/16, 14:46

Commit message

PHP extension json is now listed as dependency
 in composer.json. Extension mysqli is added to
 "suggest" section.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Nicole Hummel +1

Issues 1

Files 2

Review log 18

  1. Tymoteusz Motylewski uploaded patch set 1 03/03/16, 13:01

  2. Oliver Klee voted on patch set 1 CR +1 03/03/16, 13:13

  3. Oliver Klee commented on patch set 1 03/03/16, 13:14

    Shouldn't we also have this for 7.6 and 6.2?
  4. Christian Kuhn wrote 03/03/16, 14:00

    Patch set 2: Commit message was updated.
  5. Christian Kuhn commented on patch set 2 03/03/16, 14:00

    ok for 7.6, but not critical enough for 6.2
  6. Christian Kuhn commented on patch set 2 03/03/16, 14:01

    needs composer lock update
  7. Christian Kuhn uploaded patch set 3 03/03/16, 14:04

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 03/03/16, 14:05

  9. Wouter Wolters voted on patch set 3 CR +1 03/03/16, 14:07

  10. Christian Kuhn commented on patch set 3 CR -1 03/03/16, 14:17

    mysqli shouldn't be a hard requirement with dbal.
  11. Tymoteusz Motylewski commented on patch set 3 03/03/16, 15:12

    hmm, you're right, I forget about mysqli. Should I move it to suggest then?
  12. Benni Mack commented on patch set 3 03/03/16, 17:04

    yes. move it to suggest and we're fine.
  13. Tymoteusz Motylewski uploaded patch set 4 03/04/16, 10:47

  14. Oliver Klee voted on patch set 4 CR +1 03/04/16, 10:48

  15. Nicole Hummel voted on patch set 4 CR +1 V +1 03/04/16, 14:24

  16. Wouter Wolters voted on patch set 4 CR +1 03/04/16, 14:37

  17. Anja Leichsenring voted on patch set 4 CR +2 V +2 03/04/16, 14:46

  18. Gerrit merged patch set 4 03/04/16, 14:46