Review main Merged

47016[FEATURE] Report wrong database character set

Andreas Wolf CR +2 V +2 Normal +68 −0 updated 03/04/16, 15:09

Commit message

This adds a new report to the reports module that checks if the MySQL
database uses the right character set.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Jonas Götze +1
  • Verified V +2
    • Anja Leichsenring +2
    • Jonas Götze +1

Issues 1

Files 2

Review log 9

  1. Andreas Wolf uploaded patch set 1 03/03/16, 17:40

  2. Benni Mack commented on patch set 1 03/03/16, 18:28

    ConfigurationStatus.php:299

    english only?
  3. Jonas Götze rebased onto patch set 2 03/04/16, 14:50

  4. Jonas Götze uploaded patch set 3 03/04/16, 14:53

  5. Jonas Götze voted on patch set 3 CR +1 V +1 03/04/16, 14:54

  6. Anja Leichsenring commented on patch set 3 CR +2 V +2 03/04/16, 15:04

    works perfectly. Detected the wrong character set in my own setup -.-
  7. Gerrit merged patch set 3 03/04/16, 15:04

  8. Wouter Wolters commented on patch set 4 03/04/16, 15:06

    ConfigurationStatus.php:289

    space missing

    ConfigurationStatus.php:295

    space missing
  9. Daniel Goerz commented on patch set 4 03/04/16, 15:09

    Could this be backported to 7.6? I'd like that :)