47024[BUGFIX] Use APCu instead of APC for Caching
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Alexander Opitz +1
- Steffen Müller +1
-
Verified V +2
- Oliver Hader +2
- Alexander Opitz +1
- Steffen Müller +1
Issues 1
Files 5
- typo3/sysext/core/Classes/Cache/Backend/ApcuBackend.php8new+332 −0
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ApcuPreset.phpnew+67 −0
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ExtbaseObjectCacheFeature.php+3 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/ExtbaseObjectCache/Apc.html1+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/ExtbaseObjectCache/Apcu.html1new+37 −0
Review log 27
Show 2 earlier messages
-
Wouter Wolters voted on patch set 1 CR +1 03/04/16, 08:55
-
Mathias Brodala commented on patch set 1 CR -1 03/04/16, 08:56
I'd like to clarify the impact of having "apc" loaded and "apcu" not.ApcBackend.php:80Doesn't make this the change breaking in case someone was only using "apc" before? -
Andreas Allacher commented on patch set 1 03/04/16, 08:57
ApcBackend.php:80ReplyJust wanted to mention the same :) -
Mathias Brodala commented on patch set 1 CR 0 03/04/16, 09:07
The extension "apc" is not available for PHP >= 5.5 at all, thus no breaking change here. -
Alexander Opitz commented on patch set 1 CR -1 03/04/16, 10:42
Shouldn't the ApcPreset.php also changed?Backport to 7.6? IMHO It isn't really needed as installed APCu can be identified the old way (which coursed troubles in OpcodeCache identification).ApcBackend.php:80ReplyOnly as notice here: It isn't breaking. As of PHP >=5.5 only the APCu extension is working. -
Christian Kuhn commented on patch set 1 03/04/16, 10:45
Reply
what exactly do you mean with this sentence? could you rephrase, please? why did you vote -1? -
Alexander Opitz commented on patch set 1 03/04/16, 11:37
Reply
APCu 4.x is compatible with PHP 5.5/5.6 and uses the old apc_* functions, new apc_* fanctions and can be identified with "extension_loaded('apc')" and "extension_loaded('apcu')" APCu 5.1.x is compatible with PHP 5.6 only uses the apcu_* functions and can be identified with and "extension_loaded('apcu')" For APCu 5.1.x there is a apcu_bc extension which brings the "old" behavior back to APCu 5.1.x. -
Benni Mack uploaded patch set 2 03/04/16, 11:38
-
Benni Mack wrote 03/04/16, 18:18
Patch set 3: Published edit on patch set 2. -
Alexander Opitz voted on patch set 3 CR +1 V +1 03/07/16, 08:33
-
Wouter Wolters commented on patch set 3 CR -1 03/07/16, 08:43
ApcuBackend.php:94Can we import the complete namespace instead of a short part?ApcuBackend.php:150The exception numbers are already in use -
Benni Mack uploaded patch set 4 03/09/16, 08:05
-
Alexander Opitz voted on patch set 4 CR +1 V +1 03/18/16, 11:57
-
Steffen Müller uploaded patch set 5 03/21/16, 15:26
-
Steffen Müller commented on patch set 5 CR +1 V +1 03/21/16, 15:30
New installations from scratch set apcu as backend for extbase_object, if: * apcu installed * apcu AND apcu_bc installedApcuBackend.php:94ReplyDone -
Alexander Opitz voted on patch set 5 CR +1 V +1 03/21/16, 16:43
-
Oliver Hader commented on patch set 5 CR -1 03/21/16, 16:58
Added some remarks... since commit message says, that APC and APCu might be used side by side in edge cases, I think the prefixes (e.g. tag prefix) should be unique on the used technology (APCBE vs APCuBE)ApcuBackend.php:73FLOW3?ApcuBackend.php:98Can we use full MD5 or even SHA1 here?ApcuBackend.php:143Should that one be different to the old APC Backend? -
Oliver Hader commented on patch set 5 CR 0 03/21/16, 17:20
Removing my -1 after sorting out the "edge cases" with Benni. That would only affect PHP 5.5 with either one of them being available. Explicitly running APC and APCu side-by-side does not make sense in terms of a separated cache prefix... -
Oliver Hader commented on patch set 5 V +1 03/21/16, 17:38
Validated functionality with apcu_cache_info() -
Oliver Hader commented on patch set 5 CR +1 03/21/16, 17:41
ApcuBackend.php:98ReplyFine, since it should be behave like APC for the time being... However, hash collisions still might occurApcuBackend.php:143ReplyFine... like APC -
Oliver Hader voted on patch set 5 CR +2 V +2 03/21/16, 17:42
-
Gerrit merged patch set 5 03/21/16, 17:42
-
Oliver Hader commented on patch set 6 03/21/16, 17:43
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8b4cb1eaaa018ff91572e2850385cd4534774dc9 -
Christian Kuhn commented on patch set 6 06/14/16, 13:12
oehm ... it seems we forgot to add unit tests for this backend ... should have been easy by copying those from apc over.