47026[FEATURE] Allow Backend Logo to be set via extConf
Commit message
Review
-
Code review CR +2
- Benjamin Kott +2
- Wouter Wolters +1
- Morton Jonuschat +1
-
Verified V +2
- Benjamin Kott +2
- Morton Jonuschat +1
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/BackendController.php1+6 −5
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/backend/ext_conf_template.txt+4 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-74109-SetTheAlternativeBackendLogoViaExtensionManager.rst2new+17 −0
Review log 13
-
Benni Mack uploaded patch set 1 03/03/16, 21:05
-
Georg Ringer commented on patch set 1 03/04/16, 06:33
-
Mathias Brodala commented on patch set 1 03/04/16, 09:03
Feature-74109-SetTheAlternativeBackendLogoViaExtensionManager.rst:8Can we mention the exact configuration option here? Some people might want to set this with a site extension or similar instead of graphically. ;-) -
Mathias Brodala commented on patch set 1 CR -1 03/04/16, 09:04
BackendController.php:267Please use $extConf['backendLogo'] ?? 'EXT...' to avoid a notice. -
Benni Mack wrote 03/04/16, 09:06
Patch set 2: Published edit on patch set 1. -
Benni Mack wrote 03/04/16, 09:07
Patch set 3: Published edit on patch set 2. -
Benjamin Kott voted on patch set 3 CR +2 V +2 03/04/16, 09:09
-
Wouter Wolters voted on patch set 3 CR +1 03/04/16, 09:10
-
Mathias Brodala commented on patch set 3 03/04/16, 09:11
It's not really breaking but people will wonder about this, so maybe add an important RST for this? -
Benni Mack commented on patch set 3 03/04/16, 09:14
well, that's why I added a Feature.RST, which contains the "Impact" section, IMHO that should be sufficient. -
Morton Jonuschat voted on patch set 3 CR +1 V +1 03/04/16, 09:18
-
Gerrit merged patch set 3 03/04/16, 09:20
-
Mathias Brodala commented on patch set 4 03/04/16, 09:24
> well, that's why I added a Feature.RST, which contains the "Impact" > section, IMHO that should be sufficient. OK then.
Feature-74109-SetTheAlternativeBackendLogoViaExtensionManager.rst:8