Review main Merged

47030[BUGFIX] Fix 'Transfer selection to clipboard' button

Jan Helke CR +2 V +2 Easy +3 −0 updated 03/04/16, 15:08

Commit message

This patch reintroduces the onclick event if the function call has no
warning. This fixes the error with the not working 'Transfer selection
to clipboard' button in the list view, if the user enables every clipboard
but the normal.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Eugen Lang +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Eugen Lang +1

Issues 1

Files 1

Review log 11

  1. Jan Helke uploaded patch set 1 03/03/16, 23:38

  2. Georg Ringer voted on patch set 1 CR +1 V +1 03/04/16, 06:26

  3. Wouter Wolters voted on patch set 1 CR +1 03/04/16, 07:49

  4. Eugen Lang voted on patch set 1 CR +1 V +1 03/04/16, 10:23

  5. Christian Kuhn commented on patch set 1 03/04/16, 10:24

    testing.
  6. Anja Leichsenring voted on patch set 1 CR +1 V +1 03/04/16, 10:28

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 03/04/16, 10:28

  8. Gerrit merged patch set 1 03/04/16, 10:29

  9. Christian Kuhn commented on patch set 2 03/04/16, 10:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 70cf17eff9c0ffbceef7122db3d15ea0a335855d
  10. Frank Nägler commented on patch set 2 03/04/16, 10:40

    +1 thx for the fix!
  11. Wouter Wolters commented on patch set 2 03/04/16, 15:08

    DatabaseRecordList.php:1982

    double encoded now? Reported by Nicole within another review :)