Review main Merged

47039[TASK] Deprecate TemplateService methods

Benni Mack CR +2 V +2 Hard +252 −40 updated 03/04/16, 14:44

Commit message

The static method TemplateService::sortedKeyList is moved
to ArrayUtility::filterAndSortByNumericKeys.

The method TemplateService->removeQueryString() is
marked as deprecated.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Maier +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Maier +1

Issues 1

Files 18

Review log 8

  1. Benni Mack uploaded patch set 1 03/04/16, 10:57

  2. Benni Mack wrote 03/04/16, 11:00

    Patch set 2: Commit message was updated.
  3. Anja Leichsenring uploaded patch set 3 03/04/16, 11:56

  4. Benni Mack uploaded patch set 4 03/04/16, 12:24

  5. Anja Leichsenring voted on patch set 4 CR +1 V +1 03/04/16, 12:37

  6. Daniel Maier voted on patch set 4 CR +1 V +1 03/04/16, 14:26

  7. Anja Leichsenring voted on patch set 4 CR +2 V +2 03/04/16, 14:44

  8. Gerrit merged patch set 4 03/04/16, 14:44