47059[BUGFIX] EXT:form Validation of email
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Wouter Wolters +1
- Nicole Hummel +1
-
Verified V +2
- Jan Helke +2
- Wouter Wolters +1
- Nicole Hummel +1
Issues 1
Files 2
Review log 20
-
Florian Mast uploaded patch set 1 03/04/16, 14:56
-
Wouter Wolters commented on patch set 1 03/04/16, 15:01
-
Florian Mast uploaded patch set 2 03/04/16, 15:50
-
Nicole Hummel commented on patch set 2 CR -1 03/04/16, 16:24
not psr-2 compatible. missing tests. will do an update -
Nicole Hummel uploaded patch set 3 03/04/16, 16:33
-
Nicole Hummel voted on patch set 3 CR +1 V +1 03/04/16, 16:33
-
Florian Mast voted on patch set 3 CR +1 V +1 03/04/16, 17:14
-
Florian Mast voted on patch set 3 CR 0 V 0 03/04/16, 17:17
-
Florian Mast commented on patch set 3 CR -1 03/04/16, 17:26
Unit test calls wrong validation function. It has to call isValid() from Class EmailValidator, not validate() from super class -
Nicole Hummel commented on patch set 3 03/04/16, 17:58
@Florian: This is wrong. The function validate calls isValid() and returns the result which is used in the tests to assert the expectations. -
Wouter Wolters commented on patch set 3 CR -1 03/04/16, 17:58
will push an small update. -
Wouter Wolters uploaded patch set 4 03/04/16, 18:05
-
Nicole Hummel commented on patch set 4 V -1 03/04/16, 18:09
now the patch misses its goal. i'm on it -
Nicole Hummel uploaded patch set 5 03/04/16, 18:22
-
Nicole Hummel voted on patch set 5 CR +1 V +1 03/04/16, 18:22
-
Wouter Wolters voted on patch set 5 CR +1 V +1 03/04/16, 18:26
-
Jan Helke voted on patch set 5 CR +1 V +1 03/04/16, 18:39
-
Jan Helke voted on patch set 5 CR +2 V +2 03/04/16, 18:39
-
Gerrit merged patch set 5 03/04/16, 18:39
-
Jan Helke commented on patch set 6 03/04/16, 18:40
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit abd04d5d0a352c8ee8282529720090370d09aa9e
EmailValidator.php:35