Review main Merged

47095[TASK] Clean up typolink target and linktxt

Benni Mack CR +2 V +2 Normal +68 −62 updated 03/05/16, 16:48

Commit message

Rename $linktxt to $linkText.
Only evaluate target if forceTarget is not set.

Add a small helper method to call parseFunc on empty
$linkText that is used in 4 places within typoLink().

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Eugen Lang +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Eugen Lang +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 03/05/16, 13:00

  2. Jo Hasenau voted on patch set 1 CR +1 03/05/16, 13:08

  3. Eugen Lang voted on patch set 1 CR +1 03/05/16, 13:17

  4. Mathias Schreiber uploaded patch set 2 03/05/16, 15:41

  5. Mathias Schreiber voted on patch set 2 CR +1 V +1 03/05/16, 15:47

  6. Eugen Lang voted on patch set 2 CR +1 V +1 03/05/16, 15:51

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/05/16, 16:48

  8. Gerrit merged patch set 2 03/05/16, 16:48