47103[FEATURE] Check database default charset
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Eugen Lang +1
-
Verified V +2
- Andreas Wolf +2
- Eugen Lang +1
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-74319-CheckDefaultDatabaseCharacterSetDuringInstallationAndProvideUpdateWizardForFixingDefaultCharacterSetOtherThanUtf-8.rstnew+21 −0
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseSelect.php+36 −1
- typo3/sysext/install/Classes/Controller/Action/Tool/UpgradeWizard.php+8 −1
- typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php4+36 −0
- typo3/sysext/install/Classes/Updates/DatabaseCharsetUpdate.phpnew+109 −0
Review log 12
-
Jonas Götze uploaded patch set 1 03/05/16, 14:29
-
Jonas Götze updated the commit message in patch set 2 03/05/16, 14:36
-
Anja Leichsenring wrote 03/05/16, 14:39
Patch set 3: Commit message was updated. -
Anja Leichsenring wrote 03/05/16, 14:42
Patch set 4: Published edit on patch set 3. -
Eugen Lang commented on patch set 4 V -1 03/05/16, 14:56
get error message but no upgrade wizard provided (first install) -
Eugen Lang commented on patch set 4 V 0 03/05/16, 15:02
however the upgrade wizard for existing installation running well (install tool) -
Jonas Götze commented on patch set 4 03/05/16, 15:08
There comes no upgrade wizard during install with the patch. The user has to care for the issue there for himself currently. -
Eugen Lang voted on patch set 4 CR +1 V +1 03/05/16, 15:52
-
Andreas Wolf commented on patch set 4 CR +2 03/05/16, 16:46
Preparing for a final test currently. -
Andreas Wolf voted on patch set 4 V +2 03/05/16, 16:57
-
Gerrit merged patch set 4 03/05/16, 16:57
-
Morton Jonuschat commented on patch set 5 03/07/16, 16:24
Post -1, needs a followup for anything that's not MySQLDatabaseCheck.php:122Not checking if we actually got a valid result which is bad because the query can fail on DBMS without INFORMATION SCHEMA / SHOW VARIABLE.DatabaseCheck.php:125No check if we actually got a row?DatabaseCheck.php:127Automatic error on DBMS which don't have character_set_database variableDatabaseCheck.php:136Assumes that character_set_database always follows MySQL naming conventions