Review main Merged

47103[FEATURE] Check database default charset

Jonas Götze CR +2 V +2 Normal +210 −2 updated 03/07/16, 16:24

Commit message

Checks the default database charset during installation and provides
Upgrade Wizard to fix default charset.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Eugen Lang +1
  • Verified V +2
    • Andreas Wolf +2
    • Eugen Lang +1

Issues 1

Files 5

Review log 12

  1. Jonas Götze uploaded patch set 1 03/05/16, 14:29

  2. Jonas Götze updated the commit message in patch set 2 03/05/16, 14:36

  3. Anja Leichsenring wrote 03/05/16, 14:39

    Patch set 3: Commit message was updated.
  4. Anja Leichsenring wrote 03/05/16, 14:42

    Patch set 4: Published edit on patch set 3.
  5. Eugen Lang commented on patch set 4 V -1 03/05/16, 14:56

    get error message but no upgrade wizard provided (first install)
  6. Eugen Lang commented on patch set 4 V 0 03/05/16, 15:02

    however the upgrade wizard for existing installation running well (install tool)
  7. Jonas Götze commented on patch set 4 03/05/16, 15:08

    There comes no upgrade wizard during install with the patch. The user has to care for the issue there for himself currently.
  8. Eugen Lang voted on patch set 4 CR +1 V +1 03/05/16, 15:52

  9. Andreas Wolf commented on patch set 4 CR +2 03/05/16, 16:46

    Preparing for a final test currently.
  10. Andreas Wolf voted on patch set 4 V +2 03/05/16, 16:57

  11. Gerrit merged patch set 4 03/05/16, 16:57

  12. Morton Jonuschat commented on patch set 5 03/07/16, 16:24

    Post -1, needs a followup for anything that's not MySQL

    DatabaseCheck.php:122

    Not checking if we actually got a valid result which is bad because the query can fail on DBMS without INFORMATION SCHEMA / SHOW VARIABLE.

    DatabaseCheck.php:125

    No check if we actually got a row?

    DatabaseCheck.php:127

    Automatic error on DBMS which don't have character_set_database variable

    DatabaseCheck.php:136

    Assumes that character_set_database always follows MySQL naming conventions