47105[TASK] EXT:form - Optimize validation in InArrayValidator
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Susi Moog +1
-
Verified V +2
- Morton Jonuschat +2
- Susi Moog +1
Issues 1
Files 5
- typo3/sysext/form/Classes/Domain/Validator/AbstractValidator.php+2 −1
- typo3/sysext/form/Classes/Domain/Validator/InArrayValidator.php4+38 −2
- typo3/sysext/form/Tests/Unit/Validator/AbstractValidatorTest.php+7 −2
- typo3/sysext/form/Tests/Unit/Validator/InArrayValidatorTest.php+255 −33
- typo3/sysext/form/Tests/Unit/Validator/LengthValidatorTest.php+5 −2
Review log 24
-
Florian Mast uploaded patch set 1 03/05/16, 15:29
-
Florian Mast wrote 03/05/16, 15:58
Patch set 2: Published edit on patch set 1. -
Björn Jacob wrote 03/05/16, 16:45
Patch set 3: Published edit on patch set 2. -
Anja Leichsenring voted on patch set 3 CR +1 V +1 03/05/16, 17:49
-
Christian Kuhn commented on patch set 3 CR -1 03/05/16, 17:56
anja will push an update -
Anja Leichsenring uploaded patch set 4 03/05/16, 19:17
-
Jan Helke voted on patch set 4 CR +1 V +1 03/05/16, 20:35
-
Benni Mack commented on patch set 4 CR -1 03/05/16, 20:44
InArrayValidator.php:53no-go. use CharsetConverter() -
Florian Mast uploaded patch set 5 03/06/16, 10:10
-
Benni Mack commented on patch set 5 03/06/16, 10:13
there are some ugly white spaces in the files (if you go through gerrit you see the red superfluous spaces) -
Björn Jacob wrote 03/06/16, 10:27
Patch set 6: Published edit on patch set 5. -
Jan Helke voted on patch set 6 CR +1 V +1 03/06/16, 10:34
-
Jan Helke voted on patch set 6 CR 0 V 0 03/06/16, 11:00
-
Björn Jacob commented on patch set 6 CR -1 03/06/16, 11:01
TYPO3\CMS\Form\Tests\Unit\Validator\DateValidatorTest::validateForInvalidInputHasNotEmptyErrorResult with data set "32-03-2012" (array('%d-%m-%Y', '32-03-2012')) Error: Call to a member function exec_SELECTgetSingleRow() on null -
Benni Mack commented on patch set 6 04/01/16, 08:51
InArrayValidator.php:46use single quotes pleaseInArrayValidator.php:47use GeneralUtility::makeInstance(CharsetConverter::class) please -
Morton Jonuschat uploaded patch set 7 04/01/16, 10:19
-
Morton Jonuschat commented on patch set 7 CR +1 V +1 04/01/16, 10:24
Verified by unit tests -
Wouter Wolters commented on patch set 7 04/01/16, 10:27
InArrayValidator.php:41@param array $options missing -
Morton Jonuschat uploaded patch set 8 04/01/16, 10:28
-
Morton Jonuschat voted on patch set 8 CR +1 V +1 04/01/16, 10:29
-
Susi Moog voted on patch set 8 CR +1 V +1 04/01/16, 10:32
-
Morton Jonuschat voted on patch set 8 CR +2 V +2 04/01/16, 10:33
-
Gerrit merged patch set 8 04/01/16, 10:33
-
Morton Jonuschat commented on patch set 9 04/01/16, 10:33
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e2f0f06373c62680d2e0117ee6346069e24237be