Review main Merged

47105[TASK] EXT:form - Optimize validation in InArrayValidator

Florian Mast CR +2 V +2 Hard +307 −40 updated 04/01/16, 10:33

Commit message

The InArrayValidator is currently case sensitive. This
patchset adds a new TypoScript option "ignorecase".

Furthermore, unit tests are added to test the new option
"ignorecase". The patchset also solves an unreported
bug which occurs when using the InArrayValidator in the
form wizard.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Susi Moog +1
  • Verified V +2
    • Morton Jonuschat +2
    • Susi Moog +1

Issues 1

Files 5

Review log 24

  1. Florian Mast uploaded patch set 1 03/05/16, 15:29

  2. Florian Mast wrote 03/05/16, 15:58

    Patch set 2: Published edit on patch set 1.
  3. Björn Jacob wrote 03/05/16, 16:45

    Patch set 3: Published edit on patch set 2.
  4. Anja Leichsenring voted on patch set 3 CR +1 V +1 03/05/16, 17:49

  5. Christian Kuhn commented on patch set 3 CR -1 03/05/16, 17:56

    anja will push an update
  6. Anja Leichsenring uploaded patch set 4 03/05/16, 19:17

  7. Jan Helke voted on patch set 4 CR +1 V +1 03/05/16, 20:35

  8. Benni Mack commented on patch set 4 CR -1 03/05/16, 20:44

    InArrayValidator.php:53

    no-go. use CharsetConverter()
  9. Florian Mast uploaded patch set 5 03/06/16, 10:10

  10. Benni Mack commented on patch set 5 03/06/16, 10:13

    there are some ugly white spaces in the files (if you go through gerrit you see the red superfluous spaces)
  11. Björn Jacob wrote 03/06/16, 10:27

    Patch set 6: Published edit on patch set 5.
  12. Jan Helke voted on patch set 6 CR +1 V +1 03/06/16, 10:34

  13. Jan Helke voted on patch set 6 CR 0 V 0 03/06/16, 11:00

  14. Björn Jacob commented on patch set 6 CR -1 03/06/16, 11:01

    TYPO3\CMS\Form\Tests\Unit\Validator\DateValidatorTest::validateForInvalidInputHasNotEmptyErrorResult with data set "32-03-2012" (array('%d-%m-%Y', '32-03-2012')) Error: Call to a member function exec_SELECTgetSingleRow() on null
  15. Benni Mack commented on patch set 6 04/01/16, 08:51

    InArrayValidator.php:46

    use single quotes please

    InArrayValidator.php:47

    use GeneralUtility::makeInstance(CharsetConverter::class) please
  16. Morton Jonuschat uploaded patch set 7 04/01/16, 10:19

  17. Morton Jonuschat commented on patch set 7 CR +1 V +1 04/01/16, 10:24

    Verified by unit tests
  18. Wouter Wolters commented on patch set 7 04/01/16, 10:27

    InArrayValidator.php:41

    @param array $options missing
  19. Morton Jonuschat uploaded patch set 8 04/01/16, 10:28

  20. Morton Jonuschat voted on patch set 8 CR +1 V +1 04/01/16, 10:29

  21. Susi Moog voted on patch set 8 CR +1 V +1 04/01/16, 10:32

  22. Morton Jonuschat voted on patch set 8 CR +2 V +2 04/01/16, 10:33

  23. Gerrit merged patch set 8 04/01/16, 10:33

  24. Morton Jonuschat commented on patch set 9 04/01/16, 10:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e2f0f06373c62680d2e0117ee6346069e24237be