47129[TASK] Fluidification of Info Module
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jan Helke +1
-
Verified V +2
- Christian Kuhn +2
- Jan Helke +1
Issues 1
Files 3
Review log 12
-
Michael Oehlhof uploaded patch set 1 03/06/16, 00:43
-
Oliver Hader commented on patch set 1 03/06/16, 01:11
-
Michael Oehlhof uploaded patch set 2 03/06/16, 01:50
-
Jan Helke voted on patch set 2 CR +1 V +1 03/06/16, 09:51
-
Christian Kuhn commented on patch set 2 03/06/16, 09:55
BaseScriptClass.php:366new method in BaseScriptClass? *sniff* really really needed? looks ugly at first glance. -
Jan Helke commented on patch set 2 03/06/16, 10:13
I guess that is because BaseScriptClass::extObjContent manipulates $this->content. So this is a wrapper to return the value of $this->content. And as this call is used a couple of times it is clever to put the function in the upper class. -
Jan Helke commented on patch set 2 03/06/16, 10:14
So it can be reused in later fluidifications. -
Michael Oehlhof commented on patch set 2 03/06/16, 12:42
That is the plan. BaseScriptClass::extObjContent is used at 2 other places in the core. Because it is a public method I won't change the method, don't know if any extensions use it. -
Christian Kuhn voted on patch set 2 CR +2 V +2 03/06/16, 12:43
-
Gerrit merged patch set 2 03/06/16, 12:44
-
Stephan Großberndt commented on patch set 3 05/28/16, 10:42
Post -1: the version selector is rendered as html https://forge.typo3.org/issues/76343 -
Stephan Großberndt commented on patch set 3 05/28/16, 10:53
InfoModuleController.php:119