Review main Merged

47129[TASK] Fluidification of Info Module

Michael Oehlhof CR +2 V +2 Normal +52 −8 updated 05/28/16, 10:53

Commit message

Moved all HTML code from the PHP code to an own Fluid template.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1

Issues 1

Files 3

Review log 12

  1. Michael Oehlhof uploaded patch set 1 03/06/16, 00:43

  2. Oliver Hader commented on patch set 1 03/06/16, 01:11

    InfoModuleController.php:119

    Can we find more speaking names for the variables vContent and objContent?
  3. Michael Oehlhof uploaded patch set 2 03/06/16, 01:50

  4. Jan Helke voted on patch set 2 CR +1 V +1 03/06/16, 09:51

  5. Christian Kuhn commented on patch set 2 03/06/16, 09:55

    BaseScriptClass.php:366

    new method in BaseScriptClass? *sniff* really really needed? looks ugly at first glance.
  6. Jan Helke commented on patch set 2 03/06/16, 10:13

    I guess that is because BaseScriptClass::extObjContent manipulates $this->content. So this is a wrapper to return the value of $this->content. And as this call is used a couple of times it is clever to put the function in the upper class.
  7. Jan Helke commented on patch set 2 03/06/16, 10:14

    So it can be reused in later fluidifications.
  8. Michael Oehlhof commented on patch set 2 03/06/16, 12:42

    That is the plan. BaseScriptClass::extObjContent is used at 2 other places in the core. Because it is a public method I won't change the method, don't know if any extensions use it.
  9. Christian Kuhn voted on patch set 2 CR +2 V +2 03/06/16, 12:43

  10. Gerrit merged patch set 2 03/06/16, 12:44

  11. Stephan Großberndt commented on patch set 3 05/28/16, 10:42

    Post -1: the version selector is rendered as html https://forge.typo3.org/issues/76343
  12. Stephan Großberndt commented on patch set 3 05/28/16, 10:53