Review main Merged

47144[TASK] Fluidification of Function Module

Michael Oehlhof CR +2 V +2 Normal +44 −11 updated 06/10/16, 08:49

Commit message

Moved all HTML code from the PHP code to an own Fluid template.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 10

  1. Michael Oehlhof uploaded patch set 1 03/07/16, 00:38

  2. Wouter Wolters commented on patch set 1 CR -1 03/07/16, 07:36

    PageFunctionsController.php:243

    missing type twice here
  3. Michael Oehlhof commented on patch set 1 CR -1 03/07/16, 09:05

    I will also change the usage of the view in the else branch (line 147).
  4. Michael Oehlhof uploaded patch set 2 03/07/16, 12:40

  5. Wouter Wolters commented on patch set 2 06/07/16, 21:15

    Will review this tomorrow.
  6. Wouter Wolters commented on patch set 2 CR -1 06/10/16, 08:10

    will fix the issues

    PageFunctionsController.php:135

    no htmlspecialchars here!

    PageFunctionsController.php:136

    same here

    Main.html:4

    format raw here
  7. Wouter Wolters uploaded patch set 3 06/10/16, 08:19

  8. Wouter Wolters voted on patch set 3 CR +1 V +1 06/10/16, 08:34

  9. Frank Nägler voted on patch set 3 CR +2 V +2 06/10/16, 08:49

  10. Gerrit merged patch set 3 06/10/16, 08:49