47144[TASK] Fluidification of Function Module
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Wouter Wolters +1
-
Verified V +2
- Frank Nägler +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 10
-
Michael Oehlhof uploaded patch set 1 03/07/16, 00:38
-
Wouter Wolters commented on patch set 1 CR -1 03/07/16, 07:36
-
Michael Oehlhof commented on patch set 1 CR -1 03/07/16, 09:05
I will also change the usage of the view in the else branch (line 147). -
Michael Oehlhof uploaded patch set 2 03/07/16, 12:40
-
Wouter Wolters commented on patch set 2 06/07/16, 21:15
Will review this tomorrow. -
Wouter Wolters commented on patch set 2 CR -1 06/10/16, 08:10
will fix the issuesPageFunctionsController.php:135no htmlspecialchars here!PageFunctionsController.php:136same hereMain.html:4format raw here -
Wouter Wolters uploaded patch set 3 06/10/16, 08:19
-
Wouter Wolters voted on patch set 3 CR +1 V +1 06/10/16, 08:34
-
Frank Nägler voted on patch set 3 CR +2 V +2 06/10/16, 08:49
-
Gerrit merged patch set 3 06/10/16, 08:49
PageFunctionsController.php:243