Review main Abandoned

47150[BUGFIX] SelectTreeElement: save selected nodes of collapsed parents

Andreas Allacher CR 0 V 0 Easy +5 −0 updated 04/25/16, 17:40

Commit message

The FormEngine SelectTreeElement did not render all nodes
on loading but only expanded. Which resulted in updates
to the hidden value losing data if there are selected
nodes that haven't been expanded previously.

This change ensures that all nodes are rendered on load
and therefore the hidden value is updated correctly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Andreas Allacher uploaded patch set 1 03/07/16, 15:56

  2. Andreas Allacher wrote 03/07/16, 18:37

    Patch set 2: Published edit on patch set 1.
  3. Andreas Allacher commented on patch set 2 CR -1 03/07/16, 18:37

    I still have to verify patchset 2, will do so tomorrow.
  4. Andreas Allacher commented on patch set 2 CR 0 03/08/16, 08:19

    Just verified that patchset 2 still works
  5. Andreas Allacher commented on patch set 2 03/08/16, 08:21

    The issue also exists in 6.2, maybe we should also backport it to 6.2?
  6. Frans Saris commented on patch set 2 04/20/16, 20:05

    Hi Andreas, your approuch only works for the first not expanded level. Could you maybe give my approuch a look https://review.typo3.org/#/c/47812/
  7. Frans Saris voted on patch set 2 V -1 04/20/16, 20:05

  8. Andreas Allacher commented on patch set 2 04/20/16, 21:08

    Hi, it worked for me up to the third or fourth level but I will retry and also try your patchset.
  9. Andreas Allacher commented on patch set 2 04/20/16, 21:16

    But if your patchset works, it is probably the better fix anyway as it doesn't require pre-rendering but actually fixes the JS part of the tree.
  10. Andreas Allacher abandoned the change 04/25/16, 17:39

    Abandoned in favour of: https://review.typo3.org/#/c/47903/
  11. Andreas Allacher commented on patch set 2 04/25/16, 17:40

    Abandoned in favour of: https://review.typo3.org/#/c/47812/ (wrong patchset in previous commenct)