Review main Abandoned

47155[BUGFIX] Updating values in the fe_user session doesn't work

Bernhard Kraft CR 0 V 0 Easy +3 −1 updated 12/22/16, 19:39

Commit message

Updating values sent via the "recs" GET/POST parameter is not possible
anymore when there is no fe_user session cookie set already.

This fix resolves the problem by allowing to set the cookie when a
"recs" argument has been posted.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 7

  1. Bernhard Kraft uploaded patch set 1 03/08/16, 12:55

  2. Benni Mack commented on patch set 1 CR -1 03/09/16, 05:54

    FrontendUserAuthentication.php:623

    I think with this change the comment above just hits it right: anyone can now spam the fe_sessions with just GP variables.
  3. Bernhard Kraft commented on patch set 1 03/09/16, 09:40

    So what do you suggest? For storing known values depending on a users choice it would be possible to use a hash to validate sent values. But for custom values? You could use the same argument against powermail or formhandler when storing contact mails.
  4. Bernhard Kraft commented on patch set 1 03/09/16, 09:41

    I bet you are having a clever idea how to handle this ...
  5. Christian Kuhn commented on patch set 1 CR -2 04/01/16, 09:04

    -2 until this obvious and easy dos introduction is fixed.
  6. Anja Leichsenring commented on patch set 1 12/08/16, 19:03

    obviously no interest anymore? I will abandon the patch on my next round through gerrit, if no action has been initiated.
  7. Anja Leichsenring abandoned the change 12/22/16, 19:39