Review main Merged

47163[BUGFIX] Remove competing injects from WidgetRequestHandler

Alexander Jahn CR +2 V +2 Easy +9 −1 updated 03/18/16, 16:41

Commit message

Removing @injects introduced explicit injectFunctions
into WidgetRequestHandler.
These functions were named after the object they inject.
This resulted in two methods injecting different objects into the same
property and in the end the parent class' function reverted the local
implementation.

Review

  • Code review CR +2
    • Jan Helke +2
    • Daniel Goerz +1
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Jan Helke +2
    • Markus Klein +1
    • Nicole Hummel +1

Issues 2

Files 2

Review log 28

Show 3 earlier messages
  1. Alexander Jahn uploaded patch set 1 03/09/16, 11:13

  2. Wouter Wolters wrote 03/09/16, 11:35

    Patch set 2: Commit message was updated.
  3. Wouter Wolters commented on patch set 2 CR +1 03/09/16, 11:35

    Thanks for the patch, adjusted commit message a bit.
  1. Markus Klein commented on patch set 2 03/09/16, 12:00

    WidgetRequestHandler.php:63

    shouldn't that be adjusted too?
  2. Markus Klein commented on patch set 2 03/09/16, 12:01

    If you push a new set, please adjust the author's name also to the full name. Thanks
  3. Markus Klein uploaded patch set 3 03/10/16, 00:09

  4. Markus Klein rebased onto patch set 4 03/10/16, 00:09

  5. Markus Klein commented on patch set 4 CR +1 03/10/16, 00:10

    Fixed method signature to match parent method (PHP7 requirement) and implement check for correct class. I'm very confident that this is correct now, but I didn't test yet. Maybe Alexander can give it a shot first.
  6. Alexander Jahn commented on patch set 3 03/11/16, 09:56

    I could only test cherrypicks on 7.6. Both changesets 3 and 4 die throwing the exception introduced in changeset 3. Cant say if it works on master, but 7.6 is even more broken than before.
  7. Markus Klein commented on patch set 4 CR 0 03/11/16, 10:05

    Alexander, would you mind joining us on Slack, so we can discuss the bits and pieces here? The problem with the solution of set 2 is that it is PHP7 incompatible.
  8. Nicole Hummel voted on patch set 4 CR +1 03/11/16, 20:07

  9. Claus Due commented on patch set 4 CR -1 03/14/16, 09:37

    Throws error about signature compatibility on PHP 7
  10. Alexander Jahn uploaded patch set 5 03/14/16, 11:04

  11. Alexander Jahn commented on patch set 5 03/14/16, 11:06

    > Uploaded patch set 5. Had a quick chat with Markus. This patch should fix the issue AND be compatible with PHP 7.
  12. Andreas Kienast commented on patch set 6 03/14/16, 11:56

    Published edit on patch set 5.
  13. Andreas Kienast voted on patch set 6 CR +1 03/14/16, 11:56

  14. Markus Klein voted on patch set 6 CR +1 03/14/16, 21:29

  15. Markus Klein voted on patch set 6 V +1 03/14/16, 21:35

  16. Markus Sommer voted on patch set 6 CR +1 03/18/16, 08:36

  17. Jan Helke commented on patch set 6 V -1 03/18/16, 11:30

    Unit test break.
  18. Nicole Hummel uploaded patch set 7 03/18/16, 13:24

  19. Nicole Hummel commented on patch set 7 CR +1 V +1 03/18/16, 13:25

    Verified by running unit tests
  20. Markus Klein commented on patch set 7 CR +1 V +1 03/18/16, 13:45

    Get it in. Thanks Nicole for the fix.
  21. Markus Klein commented on patch set 7 03/18/16, 13:45

    Chance for your revotes
  22. Daniel Goerz voted on patch set 7 CR +1 03/18/16, 14:13

  23. Jan Helke voted on patch set 7 CR +2 V +2 03/18/16, 15:57

  24. Gerrit merged patch set 7 03/18/16, 15:57

  25. Jan Helke commented on patch set 8 03/18/16, 16:41

    Will do the cherry pick to 7.6