47163[BUGFIX] Remove competing injects from WidgetRequestHandler
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Daniel Goerz +1
- Markus Klein +1
- Nicole Hummel +1
-
Verified V +2
- Jan Helke +2
- Markus Klein +1
- Nicole Hummel +1
Issues 2
Files 2
Review log 28
Show 3 earlier messages
-
Markus Klein commented on patch set 2 03/09/16, 12:00
WidgetRequestHandler.php:63shouldn't that be adjusted too? -
Markus Klein commented on patch set 2 03/09/16, 12:01
If you push a new set, please adjust the author's name also to the full name. Thanks -
Markus Klein uploaded patch set 3 03/10/16, 00:09
-
Markus Klein rebased onto patch set 4 03/10/16, 00:09
-
Markus Klein commented on patch set 4 CR +1 03/10/16, 00:10
Fixed method signature to match parent method (PHP7 requirement) and implement check for correct class. I'm very confident that this is correct now, but I didn't test yet. Maybe Alexander can give it a shot first. -
Alexander Jahn commented on patch set 3 03/11/16, 09:56
I could only test cherrypicks on 7.6. Both changesets 3 and 4 die throwing the exception introduced in changeset 3. Cant say if it works on master, but 7.6 is even more broken than before. -
Markus Klein commented on patch set 4 CR 0 03/11/16, 10:05
Alexander, would you mind joining us on Slack, so we can discuss the bits and pieces here? The problem with the solution of set 2 is that it is PHP7 incompatible. -
Nicole Hummel voted on patch set 4 CR +1 03/11/16, 20:07
-
Claus Due commented on patch set 4 CR -1 03/14/16, 09:37
Throws error about signature compatibility on PHP 7 -
Alexander Jahn uploaded patch set 5 03/14/16, 11:04
-
Alexander Jahn commented on patch set 5 03/14/16, 11:06
> Uploaded patch set 5. Had a quick chat with Markus. This patch should fix the issue AND be compatible with PHP 7. -
Andreas Kienast commented on patch set 6 03/14/16, 11:56
Published edit on patch set 5. -
Andreas Kienast voted on patch set 6 CR +1 03/14/16, 11:56
-
Markus Klein voted on patch set 6 CR +1 03/14/16, 21:29
-
Markus Klein voted on patch set 6 V +1 03/14/16, 21:35
-
Markus Sommer voted on patch set 6 CR +1 03/18/16, 08:36
-
Jan Helke commented on patch set 6 V -1 03/18/16, 11:30
Unit test break. -
Nicole Hummel uploaded patch set 7 03/18/16, 13:24
-
Nicole Hummel commented on patch set 7 CR +1 V +1 03/18/16, 13:25
Verified by running unit tests -
Markus Klein commented on patch set 7 CR +1 V +1 03/18/16, 13:45
Get it in. Thanks Nicole for the fix. -
Markus Klein commented on patch set 7 03/18/16, 13:45
Chance for your revotes -
Daniel Goerz voted on patch set 7 CR +1 03/18/16, 14:13
-
Jan Helke voted on patch set 7 CR +2 V +2 03/18/16, 15:57
-
Gerrit merged patch set 7 03/18/16, 15:57
-
Jan Helke commented on patch set 8 03/18/16, 16:41
Will do the cherry pick to 7.6