Review main Abandoned

47170[BUGFIX] Allow special chars in additional parameters

Marco Huber CR 0 V 0 Easy +17 −13 updated 01/13/18, 08:49

Commit message

Allow special chars like "." and "/" in the third parameter of the link
shorthand syntax.

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 1215

  1. Marco Huber uploaded patch set 1 03/10/16, 09:52

  2. Oliver Klee commented on patch set 1 03/10/16, 11:17

    Can we please cover this with unit tests?
  3. Markus Klein commented on patch set 1 03/10/16, 12:07

    Please also make sure that links like these work as well: parameter = 51#part.one (ids may contain dots!)
  4. Daniel Goerz commented on patch set 1 03/10/16, 16:10

    ContentObjectRenderer.php:5761

    this should be (int)
  5. Marco Huber commented on patch set 2 09/02/16, 23:25

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V -1 09/02/16, 23:25 Completed build in 23s on Sat, 3 Sep, 01:25 AM Test Summary: 62 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2813

  7. Markus Klein commented on patch set 2 09/13/16, 17:32

    Needs a rebase on current master
  8. Marco Huber updated the commit message in patch set 3 12/02/16, 16:12

  9. TYPO3com voted on patch set 3 V -1 12/02/16, 16:13 Completed build in 10s on Fri, 2 Dec, 05:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5351

  10. Anja Leichsenring updated the commit message in patch set 4 12/03/16, 10:56

  11. TYPO3com voted on patch set 4 V -1 12/03/16, 10:56 Completed build in 10s on Sat, 3 Dec, 11:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5389

  12. Anja Leichsenring commented on patch set 4 CR -1 V -1 12/03/16, 10:58

    the code in ContentObjectRenderer doesn't exist anymore, so this change does not apply. Additionally, the proposed patch changes behaviour in a vital part of the system, so I opt for not backporting it into stable branches, for sure not to 6.2.
  13. Alexander Opitz commented on patch set 4 01/08/18, 11:06

    What's the state of this patch?
  14. Anja Leichsenring commented on patch set 4 01/13/18, 08:43

    this syntax is not supported anymore, last version was 7LTS. This branch is in priority bugfix mode. The patch will not make it. Please abandon.
  15. Andreas Kienast abandoned the change 01/13/18, 08:49

    Abandoned as requested by Anja