4718[BUGFIX] Locales dependency is not taken into account
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Xavier Perseguers +1
-
Verified V +2
- Andreas Wolf +2
Files 1
Review log 16
-
Andreas Wolf commented on patch set 1 09/08/11, 12:47
(1 inline comment) Looks good except one nitpick; I don't know how to (easily) test though...lang.php:122Please add a comment describing this variable - it's not instantly clear, what these "dependencies" are... -
Xavier Perseguers commented on patch set 1 09/08/11, 12:47
Stay tuned, I'm finalizing a step by step example on http://xavier.perseguers.ch/en/tutorials/typo3/articles/managing-localization-files.html -
Andreas Wolf uploaded patch set 3 09/08/11, 12:47
-
Andreas Wolf commented on patch set 3 09/08/11, 12:47
Looks good to me, approved I changed the variable comment again, because I think the variable's purpose was still not really clear. +1 by reading, but I have not tested it. -
Andreas Wolf commented on patch set 3 V 0 09/08/11, 12:47
by team member Ok, I tested it - works fine! Pushing this after my positive review. -
Xavier Perseguers commented on patch set 2 09/08/11, 12:47
No score Patch is OK as described in the bug tracker. No need to further modify it. -
Xavier Perseguers uploaded patch set 2 09/08/11, 12:47
-
Xavier Perseguers commented on patch set 2 09/08/11, 12:47
Do not submit I found a missing fallback condition -
Xavier Perseguers commented on patch set 3 09/08/11, 12:47
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 3 09/08/11, 12:47
Is it possible for you to test it? I describe the process with a user-defined language: http://xavier.perseguers.ch/en/tutorials/typo3/articles/managing-localization-files.html#c954 Alternatively you can set an arbitrary list of dependencies (let's say you take your backend in German and put a dependency with French. Then you should have your BE in German. Remove a label from German, it will fall back to English without the patch and to French with the patch, as expected. Now remove label from French as well (or do it for yet another label), it should finally fall back to English. -
Dominique Feyer commented on patch set 1 09/08/11, 12:47
Verified; Looks good to me, but someone else must approve -
Dominique Feyer commented on patch set 2 09/08/11, 12:47
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 09/08/11, 12:47
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1767/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/08/11, 12:47
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1793/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/08/11, 12:47
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1797/ : SUCCESS -
Andreas Wolf merged patch set 3 09/08/11, 12:47