Review main Merged

4718[BUGFIX] Locales dependency is not taken into account

Xavier Perseguers CR +2 V +2 Easy +34 −1 updated 06/03/13, 20:49

Commit message

Localization methods do not take global or user-defined locales
dependencies into account when retrieving a label for a given language.
Instead, they always fall back to default (English) if the requested
language key was not found.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Xavier Perseguers +1
  • Verified V +2
    • Andreas Wolf +2

Files 1

Review log 16

  1. Andreas Wolf commented on patch set 1 09/08/11, 12:47

    (1 inline comment) Looks good except one nitpick; I don't know how to (easily) test though...

    lang.php:122

    Please add a comment describing this variable - it's not instantly clear, what these "dependencies" are...
  2. Xavier Perseguers commented on patch set 1 09/08/11, 12:47

  3. Andreas Wolf uploaded patch set 3 09/08/11, 12:47

  4. Andreas Wolf commented on patch set 3 09/08/11, 12:47

    Looks good to me, approved I changed the variable comment again, because I think the variable's purpose was still not really clear. +1 by reading, but I have not tested it.
  5. Andreas Wolf commented on patch set 3 V 0 09/08/11, 12:47

    by team member Ok, I tested it - works fine! Pushing this after my positive review.
  6. Xavier Perseguers commented on patch set 2 09/08/11, 12:47

    No score Patch is OK as described in the bug tracker. No need to further modify it.
  7. Xavier Perseguers uploaded patch set 2 09/08/11, 12:47

  8. Xavier Perseguers commented on patch set 2 09/08/11, 12:47

    Do not submit I found a missing fallback condition
  9. Xavier Perseguers commented on patch set 3 09/08/11, 12:47

    Looks good to me, but someone else must approve
  10. Xavier Perseguers commented on patch set 3 09/08/11, 12:47

    Is it possible for you to test it? I describe the process with a user-defined language: http://xavier.perseguers.ch/en/tutorials/typo3/articles/managing-localization-files.html#c954 Alternatively you can set an arbitrary list of dependencies (let's say you take your backend in German and put a dependency with French. Then you should have your BE in German. Remove a label from German, it will fall back to English without the patch and to French with the patch, as expected. Now remove label from French as well (or do it for yet another label), it should finally fall back to English.
  11. Dominique Feyer commented on patch set 1 09/08/11, 12:47

    Verified; Looks good to me, but someone else must approve
  12. Dominique Feyer commented on patch set 2 09/08/11, 12:47

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 1 09/08/11, 12:47

  14. Mr. Jenkins commented on patch set 2 09/08/11, 12:47

  15. Mr. Jenkins commented on patch set 3 09/08/11, 12:47

  16. Andreas Wolf merged patch set 3 09/08/11, 12:47