Review TYPO3_7-6 Merged

47181[TASK] Properly escape all form attributes in SetupModuleController

Jigal van Hemert CR +2 V +2 Normal +26 −26 updated 11/01/16, 10:01

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Stephan Großberndt +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1213

  1. Jigal van Hemert commented on patch set 1 03/10/16, 17:10

    Cherry Picked from branch master.
  2. Stephan Großberndt commented on patch set 1 06/06/16, 19:12

    Backport not merged
  3. Jigal van Hemert commented on patch set 1 06/06/16, 20:40

    > Backport not merged Correct, because backport not reviewed.
  4. Jigal van Hemert uploaded patch set 2 10/06/16, 09:30

  5. TYPO3com voted on patch set 2 V +1 10/06/16, 09:32 Completed build in 01m 49s on Thu, 6 Oct, 11:32 AM Test Summary: 34918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-139

  6. Stephan Großberndt voted on patch set 2 CR +1 10/06/16, 09:44

  7. Stefan Neufeind voted on patch set 2 CR +1 10/06/16, 10:15

  8. Jörg Bösche voted on patch set 2 CR +1 10/29/16, 00:02

  9. Nicole Hummel commented on patch set 2 10/29/16, 00:13

    SetupModuleController.php:844

    IMHO this if/else should be simplified and hsc should be moved to the label generation.
  10. Nicole Hummel commented on patch set 2 10/29/16, 00:14

    locallang.xlf:232

    I think changing labels from html to non-html is breaking for translations. Maybe it would be better to introduce new labels.
  11. Stephan Großberndt commented on patch set 2 11/01/16, 07:42

    This is a backport
  12. Christian Kuhn commented on patch set 2 CR +2 V +2 11/01/16, 10:00

    i played around with this patch for a while and especially tested crucial stuff like resetting passwords (with and without rsa). all that seems to work and afaik we had no further regressions in master, too. reading the code, most cases are rather obvious, too. let's get that merged now.

    SetupModuleController.php:844 Reply

    let's keep that in sync with the master solution.

    locallang.xlf:232 Reply

    this has been done like above in master, too. i think we have to deal with that for the time being in 7.6
  13. Gerrit merged patch set 2 11/01/16, 10:01