47193[BUGFIX] Prevent XSS in ViewHelpers
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Daniel Goerz +1
- Mathias Schreiber +1
- Wouter Wolters +1
- Michael Oehlhof +1
- Jigal van Hemert +1
-
Verified V +2
- Helmut Hummel +2
- Mathias Schreiber +1
- Jigal van Hemert +1
Issues 1
Files 8
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php2+2 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.php3+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/CaseViewHelper.php+0 −5
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −0
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php2+9 −5
Review log 17
-
Nicole Hummel uploaded patch set 1 03/11/16, 10:17
-
Frank Nägler wrote 03/11/16, 10:24
Patch set 2: Published edit on patch set 1. -
Frank Nägler commented on patch set 2 CR +1 03/11/16, 10:25
removed spaces at end if line -
Markus Klein commented on patch set 2 03/11/16, 10:26
UrlencodeViewHelper.php:57not sure about that one. Why? <f:format.rawurlencode>{foo}</f:format.rawurlencode> IMO foo must be escaped here. -
Markus Klein commented on patch set 2 CR +1 03/11/16, 10:33
UrlencodeViewHelper.php:57Replymy fault. rawurlencode kills all possible special chars that would be covered by htmlspecialchars(), so this is OK. -
Nicole Hummel commented on patch set 2 03/11/16, 10:34
UrlencodeViewHelper.php:57ReplyThat would cause double encoding on foo what would be wrong and not expected by the user. that would mean rawurlencode(htmlspecialchars(<script>alert('xss')</script>)) already rawurlencode(<script>alert('xss')</script>) is enough escapting to prevent xss (%3Cscript%3Ealert%28%27xss%27%29%3C%2Fscript%3E) -
Helmut Hummel commented on patch set 2 CR -1 03/11/16, 15:24
On glitch in DateViewHelper. Rest looks good, thanks!DebugViewHelper.php:43And especially the children can be of different type than stringDebugViewHelper.php:50good catch!DateViewHelper.php:90This is good to be removed!DateViewHelper.php:95This must be kept. <f:format.date>{dateTimeObject}</f:format.date> The value of renderChildren can be a datetime object -
Nicole Hummel uploaded patch set 3 03/11/16, 15:34
-
Markus Klein voted on patch set 3 CR +1 03/11/16, 16:21
-
Andreas Kienast wrote 03/11/16, 16:27
Patch set 4: Published edit on patch set 3. -
Wouter Wolters voted on patch set 4 CR +1 03/11/16, 19:45
-
Mathias Schreiber commented on patch set 4 CR +1 V +1 03/12/16, 17:05
Awesome idea btw. to document WHY escaping was disabled -
Jigal van Hemert voted on patch set 4 CR +1 V +1 03/12/16, 23:23
-
Michael Oehlhof voted on patch set 4 CR +1 03/13/16, 13:04
-
Daniel Goerz voted on patch set 4 CR +1 03/13/16, 21:35
-
Helmut Hummel voted on patch set 4 CR +2 V +2 03/13/16, 21:44
-
Gerrit merged patch set 4 03/13/16, 21:44