47238[!!!][TASK] Use .gz for compressed files
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php2+7 −7
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-75043-UseGzInsteadOfGzipForStaticallyCompressedFiles.rst1new+57 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/CleanUp.php+1 −0
- _.htaccess+6 −6
Review log 8
-
Andreas Kienast uploaded patch set 1 03/14/16, 11:54
-
Christian Kuhn commented on patch set 1 03/14/16, 11:58
I'm not really a very big fan at first view: Changing these endings forces many web servers to change its configuration and usually leads to "no css loaded" if it fails in FE. Do we really need to change that and force people to adapt .htaccess / apache configs? -
Andreas Kienast commented on patch set 1 03/14/16, 12:01
Well, the arguments in the ticket sound meaningful to me. I'm free for discussions on that patch and have no strong opinion if this patch is BS :) -
Markus Klein commented on patch set 1 03/14/16, 21:40
While the impact on out-of-the-box installations using the htaccess file is pretty low, the impact for existing installations, especially when the apache configuration is in the vhost, is a lot higher. I propose to extensively discuss this change in the core team and maybe even make a voting about it. I'm yet undecided.ResourceCompressor.php:50why should the z be optional?Breaking-75043-UseGzInsteadOfGzipForStaticallyCompressedFiles.rst:51same here -
Andreas Kienast commented on patch set 1 03/15/16, 07:10
ResourceCompressor.php:50ReplyThat's a mistake, I changed it to (\\.gz(ip)?)?$ at first. -
Andreas Kienast commented on patch set 2 03/15/16, 07:10
Published edit on patch set 1. -
Andreas Kienast commented on patch set 2 CR -2 03/15/16, 07:10
-2 until we cleared whether this patch will make it into the Core. -
Andreas Kienast abandoned the change 09/02/16, 08:09