47265[BUGFIX] Correctly determine previously used language in localization wizard
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Susi Moog +2
- Frank Nägler +1
-
Verified V +2
- Andreas Kienast +2
- Susi Moog +2
- Frank Nägler +1
Issues 1
Files 3
Review log 22
-
Andreas Kienast uploaded patch set 1 03/15/16, 10:56
-
Andreas Kienast uploaded patch set 2 03/15/16, 10:58
-
Andreas Kienast commented on patch set 2 CR -2 03/16/16, 08:00
On it, I will change this patch to use the registry due to further bugfixes. -
Dmitry Dulepov commented on patch set 2 03/16/16, 08:01
Registry? Why? :) -
Andreas Kienast commented on patch set 2 03/16/16, 08:03
Because holding a information that most likely does not change ever again is imo better than fetching it over and over again, especially if you need that information at multiple locations. -
Dmitry Dulepov commented on patch set 2 03/16/16, 08:10
I'd prefer fetching because: 1. Registry is also in the database, so does not matter where you fetch from 2. This will bloat registry and make it slower to fetch from. -
Andreas Kienast commented on patch set 2 03/16/16, 08:18
You're right, I didn't know the registry is always fully exposed. -
Andreas Kienast uploaded patch set 3 03/16/16, 08:30
-
Andreas Kienast voted on patch set 3 CR 0 03/16/16, 08:31
-
Andreas Kienast uploaded patch set 4 03/16/16, 08:40
-
Andreas Kienast commented on patch set 4 03/16/16, 08:42
I put some logic into a service class which will be used for further bugfixes. -
Susi Moog commented on patch set 4 CR -1 03/16/16, 11:48
Isn't your service (as well as a lot of the things in the controller) a repository? Purely from what it does I'd say name it repository. -
Andreas Kienast uploaded patch set 5 03/16/16, 12:18
-
Susi Moog commented on patch set 5 V -1 03/16/16, 13:20
Thanks, looks much better. I get a 500 error on testing: I have one element in default. --> copy to German (now 1 element in German) --> copy to 2n Lang form German (now 1 element in 2nd Lang) Now I have: - no translate button on German column. - Translate button on 2nd Language (which results in a 500 if pressed and continued) From what I'd expect I'd say the translate button should be gone in 2nd Language, too. -
Andreas Kienast commented on patch set 5 03/16/16, 13:22
That the button appears in the 2nd column is another bug. Unfortunately, this becomes a breaking change because the function that renders this button takes an array of all UIDs of the *default* language, not of its origin language. -
Susi Moog commented on patch set 5 CR +1 V +1 03/16/16, 13:29
ok. you are the language master, aside from that bug it works as advertised. -
Frank Nägler uploaded patch set 6 03/16/16, 19:14
-
Frank Nägler voted on patch set 6 CR +1 V +1 03/16/16, 19:14
-
Susi Moog voted on patch set 6 CR +2 V +2 03/17/16, 07:44
-
Andreas Kienast voted on patch set 6 CR +2 V +2 03/17/16, 07:44
-
Gerrit merged patch set 6 03/17/16, 07:44
-
Andreas Kienast commented on patch set 7 03/17/16, 07:44
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 76cdc666dff125fa419ca8ac2c040afa2b4f2f8e