Review main Abandoned

47278[BUGFIX] Decode htmlentities in page title in access module

Andreas Kienast CR 0 V 0 Easy +1 −1 updated 03/15/16, 17:30

Commit message

Having a page called ``"foo" & bar`` gets rendered as
``"foo" & bar`` in the Access module due to missing
decoding of entities. This patch decodes the entities back to their
human-readable form.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 03/15/16, 14:31

  2. Oliver Hader commented on patch set 1 03/15/16, 16:29

    Please provide some more information in the commit message, why this change is required. This way, it's easier to understand changes in the past. Thanks
  3. Andreas Kienast updated the commit message in patch set 2 03/15/16, 16:31

  4. Oliver Hader commented on patch set 2 CR -1 03/15/16, 16:40

    Hm... the change fixes the issue, however that's the wrong place IMO. Having multiple chained view helpers would result in the same double encoded values (e.g. using "{variable -> f:format.crop(maxCharacters:20) -> f:format.crop(maxCharacters:20) -> f:format.crop(maxCharacters:20)}" Thus, the basic problem is in Fluid to avoid double encoding on arbitrary chained view helpers...
  5. Oliver Hader commented on patch set 2 03/15/16, 16:59

  6. Oliver Hader abandoned the change 03/15/16, 17:30

    Fixed in upstream Fluid repository