Review main Merged

47291[BUGFIX] Add missing parameters to getFiles

Susi Moog CR +2 V +2 Easy +5 −2 updated 03/16/16, 18:54

Commit message

InaccessibleFolder extends Folder and the definition of its methods 
should therefor be compatible to each other.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 7

  1. Susi Moog uploaded patch set 1 03/16/16, 14:23

  2. Frank Nägler commented on patch set 1 03/16/16, 14:36

    InaccessibleFolder.php:81

    this method return nothing!?

    InaccessibleFolder.php:122

    the method return nothing!?
  3. Susi Moog commented on patch set 2 03/16/16, 14:39

    Published edit on patch set 1.
  4. Susi Moog commented on patch set 3 03/16/16, 14:39

    Published edit on patch set 2.
  5. Frank Nägler voted on patch set 3 CR +1 V +1 03/16/16, 16:34

  6. Andreas Kienast voted on patch set 3 CR +2 V +2 03/16/16, 18:54

  7. Gerrit merged patch set 3 03/16/16, 18:54