Review main Merged

47300[TASK] Replace test images in install tool

Frank Nägler CR +2 V +2 Expert +1394 −101 updated 04/14/16, 07:55

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Susi Moog +1
    • Benni Mack +1

Issues 1

Files 52

Show 32 more files

Review log 13

  1. Frank Nägler uploaded patch set 1 03/17/16, 12:01

  2. Benni Mack commented on patch set 1 03/17/16, 15:49

    btw. this makes our package 1 MB bigger.
  3. Andreas Kienast commented on patch set 1 03/17/16, 15:54

    Where is Test.bmp used?
  4. Frank Nägler commented on patch set 1 03/18/16, 10:14

    we could remove the two big images: Test.bmp and Test.tga ... this would save 800KB.... imho tga is not relevant and bmp!? anyone use this format? did we need it in our tests?
  5. Frank Nägler uploaded patch set 2 03/18/16, 17:16

  6. Benni Mack voted on patch set 2 V +1 03/18/16, 20:54

  7. Jigal van Hemert commented on patch set 2 03/19/16, 23:18

    Years ago someone wanted to change the test images. At that time Kasper was asked if that was fine with him and (if I remember correctly) he kindly requested to keep the original images as a reminder of the origin of TYPO3 and the values of its creator. Has something changed in this regard? Has Kasper changed his mind?
  8. Benni Mack commented on patch set 2 CR -2 03/21/16, 14:42

    Checking with Kasper for now.
  9. Benni Mack voted on patch set 2 CR +1 04/14/16, 05:39

  10. Susi Moog voted on patch set 2 CR +1 V +1 04/14/16, 07:54

  11. Jan Helke voted on patch set 2 CR +1 V +1 04/14/16, 07:55

  12. Anja Leichsenring voted on patch set 2 CR +2 V +2 04/14/16, 07:55

  13. Gerrit merged patch set 2 04/14/16, 07:55