47300[TASK] Replace test images in install tool
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Jan Helke +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2
- Anja Leichsenring +2
- Jan Helke +1
- Susi Moog +1
- Benni Mack +1
Issues 1
Files 52
- Build/Resources/Public/Less/InstallTool.less+18 −4
- typo3/sysext/install/Classes/Controller/Action/Tool/TestSetup.php+25 −21
- typo3/sysext/install/Classes/ViewHelpers/Format/ImageMagickCommandsViewHelper.php+3 −3
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/CombiningImages.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/ConvertImageFormatsToJpg.html+4 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/DisplayTwinImage.html+41 −64
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/Gdlib.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/ScalingImages.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/TestSetup/WriteGifAndPng.html+3 −1
- typo3/sysext/install/Resources/Public/Css/InstallTool.css+15 −3
- typo3/sysext/install/Resources/Public/Images/TestInput/BackgroundCombine.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/BackgroundGreen.gifdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/BackgroundOrange.gifnewbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/MaskBlackWhite.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/MaskCombine.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.bmpdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.pcxdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.pngbinary
Show 32 more files
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.svgnew+1279 −0
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.tgadeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Test.tifbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Transparent.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestInput/Transparent.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Combine-1.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Combine-2.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-box.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-box.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-niceText.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-niceText.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-shadow.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-shadow.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-simple.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-simple.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-text.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-text.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-ai.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-bmp.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-gif.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-jpg.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-pcx.jpgdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-pdf.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-png.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-tga.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Read-tif.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Scale-gif.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Scale-jpg.jpgbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Scale-png.pngbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Write-gif.gifbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Write-png.pngbinary
- typo3/sysext/install/Resources/Public/Images/bg_transparent_emulation.pngnewbinary
Review log 13
-
Frank Nägler uploaded patch set 1 03/17/16, 12:01
-
Benni Mack commented on patch set 1 03/17/16, 15:49
btw. this makes our package 1 MB bigger. -
Andreas Kienast commented on patch set 1 03/17/16, 15:54
Where is Test.bmp used? -
Frank Nägler commented on patch set 1 03/18/16, 10:14
we could remove the two big images: Test.bmp and Test.tga ... this would save 800KB.... imho tga is not relevant and bmp!? anyone use this format? did we need it in our tests? -
Frank Nägler uploaded patch set 2 03/18/16, 17:16
-
Benni Mack voted on patch set 2 V +1 03/18/16, 20:54
-
Jigal van Hemert commented on patch set 2 03/19/16, 23:18
Years ago someone wanted to change the test images. At that time Kasper was asked if that was fine with him and (if I remember correctly) he kindly requested to keep the original images as a reminder of the origin of TYPO3 and the values of its creator. Has something changed in this regard? Has Kasper changed his mind? -
Benni Mack commented on patch set 2 CR -2 03/21/16, 14:42
Checking with Kasper for now. -
Benni Mack voted on patch set 2 CR +1 04/14/16, 05:39
-
Susi Moog voted on patch set 2 CR +1 V +1 04/14/16, 07:54
-
Jan Helke voted on patch set 2 CR +1 V +1 04/14/16, 07:55
-
Anja Leichsenring voted on patch set 2 CR +2 V +2 04/14/16, 07:55
-
Gerrit merged patch set 2 04/14/16, 07:55