47309[TASK] Use file_get_contents instead of getUrl()
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Gorges +1
- Christian Kuhn +1
- Andreas Kienast +1
- Philipp Gampe +1
-
Verified V +2
- Benni Mack +2
- Daniel Gorges +1
- Andreas Kienast +1
Issues 1
Files 30
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexFetch.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −4
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+6 −6
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Messaging/AbstractStandaloneMessage.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php2+11 −7
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+4 −4
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+7 −7
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+3 −3
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/impexp/Classes/Export.php+3 −3
- typo3/sysext/impexp/Classes/Import.php+2 −2
- typo3/sysext/indexed_search/Classes/FileContentParser.php+1 −1
Show 10 more files
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php3+11 −5
- typo3/sysext/install/Classes/Controller/Action/Tool/AllConfiguration.php+1 −1
- typo3/sysext/install/Classes/Service/SqlExpectedSchemaService.php+2 −2
- typo3/sysext/install/Classes/Updates/ExtensionManagerTables.php+4 −4
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/lowlevel/Classes/CleanerCommand.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/MicroDataSchema.php+1 −1
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+1 −1
- typo3/sysext/t3editor/Classes/T3editor.php+1 −1
- typo3/sysext/version/Classes/Hook/PreviewHook.php+1 −1
Review log 14
-
Benni Mack uploaded patch set 1 03/18/16, 07:54
-
Benni Mack commented on patch set 1 CR -1 03/18/16, 08:55
gotta check the other places as well - also need to validate the tests. -
Benni Mack uploaded patch set 2 03/18/16, 20:21
-
Benni Mack uploaded patch set 3 03/18/16, 23:18
-
Philipp Gampe commented on patch set 3 03/19/16, 18:51
PageRenderer.php:2010why silence warnings?ExtensionCompatibilityTester.php:122I would prefer an is_file check here instead of hinding warnings (e.g. permission etc).ExtensionCompatibilityTester.php:208a failure to read an existing file or it's contents would be converted into an empty string here. I think any error should bubble up and be displayed to the user (who is using the install tool, thus he is a technician). -
Benni Mack commented on patch set 3 03/21/16, 06:20
PageRenderer.php:2010Replywe could also add a is_file() around it. But getUrl() does @ as well. so we just keep the logic as is.ExtensionCompatibilityTester.php:208Replyyou should try out the functionality and the tests :) - without the @ in front of file_get_contents(). The functionality is called even when the file is empty (behaviour as before) but then would throw a PHP warning. However the code is also executed when NO protocoFile is executed. But I think and is_file() check would do it. -
Benni Mack uploaded patch set 4 03/21/16, 07:15
-
Philipp Gampe commented on patch set 4 CR +1 03/22/16, 15:09
Thank you for updating the patch. -
Andreas Kienast voted on patch set 4 CR +1 03/24/16, 08:59
-
Andreas Kienast voted on patch set 4 V +1 03/24/16, 15:35
-
Christian Kuhn voted on patch set 4 CR +1 03/25/16, 09:12
-
Daniel Gorges voted on patch set 4 CR +1 V +1 03/29/16, 05:21
-
Benni Mack voted on patch set 4 CR +2 V +2 03/29/16, 05:24
-
Gerrit merged patch set 4 03/29/16, 05:24