Review main Abandoned

47312[BUGFIX] Correct order of fluid_styled_content output for textmedia

Jan Fässler CR 0 V 0 Easy +3 −3 updated 12/22/17, 08:44

Commit message

The textmedia CE does now render the image after the text if "Beside
Text, right" is selected as positioning.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 36

Show 11 earlier messages
  1. Jan Fässler uploaded patch set 1 03/18/16, 09:13

  2. Jan Helke updated the commit message in patch set 2 03/18/16, 12:45

  3. Jan Helke commented on patch set 2 03/18/16, 14:31

    Textmedia.html:9

    Do we really need to nest the if statements here that deep? I guess from reading the code, the following would also work: - if above -- MediaGallery - if intext -- if left --- MediaGallery And than we could also remove all the f:then and f:else tags, because there are no else-parts anymore.

    Textmedia.html:31

    Same as above.
  4. Gianluigi Martino uploaded patch set 3 03/20/16, 12:32

  5. Benni Mack commented on patch set 4 03/21/16, 07:19

    Published edit on patch set 3.
  6. Gianluigi Martino updated the commit message in patch set 5 03/25/16, 10:04

  7. Gianluigi Martino commented on patch set 5 CR +1 V +1 03/25/16, 10:04

    its better to use AND and OR conditions for master. uploading patch for master
  8. Gianluigi Martino uploaded patch set 6 03/25/16, 10:23

  9. Gianluigi Martino uploaded patch set 7 03/25/16, 11:05

  10. Wouter Wolters updated the commit message in patch set 8 03/25/16, 11:38

  11. Gianluigi Martino uploaded patch set 9 03/27/16, 18:44

  1. Riccardo De Contardi commented on patch set 9 V -1 03/28/16, 20:49

    on both "in text, right" and "beside text, right" the text now occupies 100% of the width and the images are put below it; the css must be reworked, too.
  2. Gianluigi Martino commented on patch set 9 03/28/16, 21:06

    We known about the css but its better to split it in two patches. Before we have know if this patch is ok. Don't forget, this patch only fix the html structure
  3. Riccardo De Contardi commented on patch set 9 V +1 03/28/16, 21:23

    @gianluigi then my vote becomes +1 because the patch does what it says (Tested under all circumstances). <div class="ce-textpic ce-center ce-above"> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> <div class="ce-bodytext">...</div> </div> <div class="ce-textpic ce-right ce-above"> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> <div class="ce-bodytext">...</div> </div> <div class="ce-textpic ce-left ce-above"> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> <div class="ce-bodytext">...</div> </div> <div class="ce-textpic ce-center ce-below"> <div class="ce-bodytext">...</div> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> </div> <div class="ce-textpic ce-right ce-below"> <div class="ce-bodytext">...</div> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> </div> <div class="ce-textpic ce-left ce-below"> <div class="ce-bodytext">...</div> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> </div> <div class="ce-textpic ce-right ce-intext"> <div class="ce-bodytext">...</div> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> </div> <div class="ce-textpic ce-left ce-intext"> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> <div class="ce-bodytext">...</div> </div> <div class="ce-textpic ce-right ce-intext ce-nowrap"> <div class="ce-bodytext">...</div> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> </div> <div class="ce-textpic ce-left ce-intext ce-nowrap"> <div class="ce-gallery" data-ce-columns="1" data-ce-images="1">...</div> <div class="ce-bodytext">...</div> </div> P.S. with the HTML given, I don't know how to obtain the "in text, right" :S
  4. Markus Sommer voted on patch set 9 CR +1 V +1 04/01/16, 11:45

  5. Daniel Goerz voted on patch set 9 CR +1 V +1 04/01/16, 19:19

  6. Markus Klein commented on patch set 9 04/01/16, 19:34

    Shouldn't that be fixed on 7.6 too?
    This is not a correct english sentence.
    no empty line before the change id please. (make sure you use the correct commit hook!)
  7. Daniel Goerz commented on patch set 9 04/01/16, 19:36

    Markus, there is this patch for 7.6 https://review.typo3.org/#/c/47391/2
  8. Daniel Goerz updated the commit message in patch set 10 04/01/16, 19:40

  9. Daniel Goerz updated the commit message in patch set 11 04/01/16, 19:41

  10. Daniel Goerz voted on patch set 11 CR +1 V +1 04/01/16, 19:41

  11. Riccardo De Contardi commented on patch set 11 V +1 04/01/16, 19:50

    works as on my previous comment
  12. Markus Klein voted on patch set 11 CR +1 04/01/16, 21:14

  13. Markus Klein commented on patch set 11 CR 0 04/01/16, 21:15

    Can this cause a problem in 7.6 for existing sites? Can it break the layout?
  14. Daniel Goerz commented on patch set 11 04/01/16, 21:22

    It might have an impact since the rendered markup is changed. Is this a good enough reason to not backport at all? I am really not sure what the worst case scenario might be...
  15. Frank Nägler commented on patch set 11 CR -1 04/04/16, 09:04

    change the output is a breaking change. this patch should not go into 7.6
  16. Christian Kuhn updated the commit message in patch set 12 04/04/16, 14:01

  17. Christian Kuhn commented on patch set 12 CR -1 04/04/16, 14:07

    What it changes: fluid-styled-content with loaded css TS: If a text+media element is created, having the image "beside text, right", then, with applied patch, the image html is now below the text. The default css stumbles with applied patch, the image is then shown below the text, and now - without patch - next to the text. So, for master, css+html depend on each other, so both should be changed in one patch. This patch here should thus be changed to include both the html and the css change, please. For 7.6: Frank and me think this is breaking and we don't think this patch is important enough to risk broken pages in FE for minor upgrades, especially for those sites that do not load the fluid_styled_content css.
  18. Frank Nägler commented on patch set 12 CR -1 04/04/16, 14:08

    agree with Lolli.
  19. Mathias Schreiber wrote 04/09/16, 19:04

    Topic set to UXW
  20. Wouter Wolters commented on patch set 12 06/07/16, 21:22

    ping
  21. Frank Nägler commented on patch set 12 11/07/16, 14:36

    no changes since four month, anyone who will take care?
  22. Benni Mack commented on patch set 12 09/20/17, 14:53

    ping. still necessary due to the rewrite?
  23. Riccardo De Contardi commented on patch set 12 09/20/17, 19:46

    @Benni AFAICS the issue is still there: in "intext,right" and "beside text, right" the html of the image is still written before the text. As I wrote, if we switch the position of these elements, I don't know how to render them correctly with the CSS (maybe the case beside text, right could be done with display:flex). Here is a pen that shows the problem: https://codepen.io/erredeco/pen/qPNdej
  24. Benjamin Kott commented on patch set 12 12/22/17, 08:43

    The current implementation is fine as is, the rendering only works with the optional fsc styles included. Also there are enough css classes available like `ce-textpic ce-right ce-intext` to reorder the markup with css options like `flexbox` like you want. This change is obsolete and i will abdon this change.
  25. Benjamin Kott abandoned the change 12/22/17, 08:44

    Current implementation is fine as is, if its nessesary to reorder the contents please use css for that.