Review main Merged

47330[BUGFIX] EXT:filelist Deleting a folder shows "Yes, delete this folder"

Michael Oehlhof CR +2 V +2 Easy +10 −2 updated 03/21/16, 09:30

Commit message

The text on the OK button was changed from "Yes, delete this file" to
"Yes, delete this folder" when a folder should be deleted.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Riccardo De Contardi +1

Issues 1

Files 5

Review log 9

  1. Michael Oehlhof uploaded patch set 1 03/19/16, 10:10

  2. Wouter Wolters voted on patch set 1 CR +1 03/20/16, 15:01

  3. Riccardo De Contardi commented on patch set 1 V -1 03/20/16, 15:49

    It doesn't work for me... my test: 1) install the patch; 2) clear cache from install tool; 3) filelist module > click on a folder with a subfolder; 4) click on "extended view"; 5) try to delete the subfolder clicking on the trash icon result: the folder name is wrapped in single quotes, but the button still reads "Yes, delete this file"
  4. Michael Oehlhof commented on patch set 1 03/20/16, 18:15

    That's strange. I just did it like you described here, it shows "Yes, delete this folder".
  5. Riccardo De Contardi commented on patch set 1 V 0 03/20/16, 20:15

    @Michael I am perplexed... how can I post you here a file?
  6. Riccardo De Contardi commented on patch set 1 V +1 03/20/16, 20:51

    patch works now, apparently it was a browser cache problem.
  7. Frank Nägler voted on patch set 1 CR +1 03/21/16, 09:12

  8. Frank Nägler voted on patch set 1 CR +2 V +2 03/21/16, 09:30

  9. Gerrit merged patch set 1 03/21/16, 09:30