47343[BUGFIX] Extension Manager: Use JsonView directly
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Frank Nägler +1
- Benni Mack +1
-
Verified V +2
- Oliver Hader +2
- Frank Nägler +1
Issues 1
Files 5
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php1+45 −14
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+34 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/CheckDependencies.jsondeleted+0 −8
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/UpdateCommentForUpdatableVersions.jsondeleted+0 −4
- typo3/sysext/extensionmanager/Resources/Private/Templates/UpdateFromTer/UpdateExtensionListFromTer.jsondeleted+0 −9
Review log 16
-
Benni Mack uploaded patch set 1 03/21/16, 17:39
-
Frank Nägler uploaded patch set 2 03/21/16, 21:15
-
Benni Mack updated the commit message in patch set 3 03/21/16, 21:41
-
Oliver Hader voted on patch set 3 CR +1 03/21/16, 21:53
-
Benni Mack commented on patch set 4 03/21/16, 21:54
Published edit on patch set 3. -
Benni Mack voted on patch set 4 CR +1 03/21/16, 21:54
-
Oliver Hader commented on patch set 4 CR +1 V +1 03/21/16, 23:01
Download::installFromTer could be migrated as well - however this is more tricky to the dependent HTML message rendering... Fine and better for the time being -
Frank Nägler voted on patch set 4 CR +1 V +1 03/21/16, 23:10
-
Oliver Hader voted on patch set 4 CR +2 V +2 03/21/16, 23:21
-
Gerrit merged patch set 4 03/21/16, 23:21
-
Nicole Hummel commented on patch set 5 03/22/16, 22:18
Post -1. Extension installation with dependencies is broken now. JSONView is not able to transform an Extension object. #1: PHP Warning: Missing argument 1 for TYPO3\CMS\Extensionmanager\Domain\Model\Extension::getCategoryIndexFromStringOrNumber(), called in typo3\sysext\extbase\Classes\Reflection\ObjectAccess.php on line 126 and defined in typo3\sysext\extensionmanager\Classes\Domain\Model\Extension.php line 237 -
Frank Nägler commented on patch set 5 03/22/16, 22:28
don't get yet, we never assigned an extension model to the view. can you give me an example? which extension / process trigger this error? -
Nicole Hummel commented on patch set 5 03/22/16, 22:34
Extension objects are included in the dependencies array. Just tried to install introduction package which requires bootstrap_package -
Nicole Hummel commented on patch set 5 03/22/16, 22:36
JsonView has an own implementation for the transformation of objects with the help of reflections. This is a big change in comparison to the ViewHelper used before. -
Nicole Hummel commented on patch set 5 03/22/16, 23:09
DownloadController.php:188What was the reason for changing the public function and making the second argument optional with this patch? -
Frank Nägler commented on patch set 5 03/23/16, 08:43
I can't answer now all your questions, maybe later this evening in slack... 1) Installation of introduction with all dependency works for me without any problems 2) the default for the parameter was commited by accident, I tried to test something, but I don't see here a big problem, did you?