Review main Merged

47347[BUGFIX] Re-allow t3d export from ID 0

Benni Mack CR +2 V +2 Normal +46 −47 updated 03/22/16, 13:22

Commit message

During the refactoring of the impexp module a check for the
page ID was introduced to show the pagetree and additional
fields only if a page ID was given, which disallows to export
records on ID 0.

Additionally, a minor JavaScript bug which popped up then
is fixed as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Hader +1

Issues 1

Files 2

Review log 11

  1. Benni Mack uploaded patch set 1 03/21/16, 19:24

  2. Wouter Wolters commented on patch set 1 03/21/16, 19:56

    ticket is reported for 7.6... so my guess is that is needs to be backported to 7.6 as well.
  3. Benni Mack commented on patch set 1 03/21/16, 20:04

    works in 7.6 - tried it in master - did not work. seems like the ticket was assigned wrongly. I came up with the problem/fix independently because of the t3d export for the introduction package.
  4. Oliver Hader commented on patch set 1 03/21/16, 21:16

    The very issue that is changed in this change set is present in 7.6 as well and has been introduced with issue ##72699 - which never(!) should have been back-ported to a stable branch... The issue #75183 (referenced by this change-set) however does not seem to be related at all. The warnings occur in both 7.6 and master for any sys_* table on the root-level (which is obvious)
  5. Benni Mack commented on patch set 1 03/21/16, 21:33

    my bad, tested it with 7.6.2 on a live version, it worked there.
  6. Benni Mack updated the commit message in patch set 2 03/21/16, 22:00

  7. Oliver Hader commented on patch set 2 03/21/16, 23:22

    Configuration.html:28

    This line seems to be duplicated (was like that before this patch already)
  8. Oliver Hader uploaded patch set 3 03/21/16, 23:24

  9. Oliver Hader voted on patch set 3 CR +1 V +1 03/21/16, 23:24

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 03/22/16, 13:19

  11. Gerrit merged patch set 3 03/22/16, 13:22