Review TYPO3_7-6 Merged

47358[BUGFIX] Re-allow t3d export from ID 0

Christian Kuhn CR +2 V +2 Normal +47 −49 updated 03/30/16, 17:28

Commit message

During the refactoring of the impexp module a check for the
page ID was introduced to show the pagetree and additional
fields only if a page ID was given, which disallows to export
records on ID 0.

Additionally, a minor JavaScript bug which popped up then
is fixed as well.

Review

  • Code review CR +2
    • Benni Mack +2
    • Bernhard Kraft +1
    • Oliver Hader +1
  • Verified V +2
    • Benni Mack +2
    • Bernhard Kraft +1
    • Oliver Hader +1

Issues 1

Files 1

Review log 8

  1. Christian Kuhn uploaded patch set 1 03/22/16, 14:40

  2. Christian Kuhn commented on patch set 1 03/22/16, 14:42

    Manual backport, please test before merge! @olly / @benni: could you give this one a shot on testing + reading in 7.6, the patch changed a lot since feature #19157 and #72764 were merged to master in between, so both js and html are different.
  3. Bernhard Kraft voted on patch set 1 CR +1 03/23/16, 11:00

  4. Bernhard Kraft commented on patch set 1 V +1 03/23/16, 17:44

    Works. Without the patch I get a message/warning "There were no records available." upon export. With the patch everything works as expected. I did not run the unit/functional tests tough.
  5. Oliver Hader voted on patch set 1 CR +1 03/30/16, 17:19

  6. Oliver Hader voted on patch set 1 V +1 03/30/16, 17:27

  7. Benni Mack voted on patch set 1 CR +2 V +2 03/30/16, 17:28

  8. Gerrit merged patch set 1 03/30/16, 17:28