Review main Merged Breaking

47361[!!!][TASK] Spread TypeConverter priorities

Bernhard Kraft CR +2 V +2 Normal +37 −21 updated 12/08/16, 00:39

Commit message

The priorities of the "TypeConverter" classes are densly packed.

With the current situation it is not possible to create a custom
TypeConverter with higher priority than "ObjectConverter" but
lower than "PersistentObjectConverter".

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
  • Verified V +2
    • Susi Moog +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 22

Show 2 more files

Review log 912

  1. Bernhard Kraft uploaded patch set 1 03/22/16, 19:15

  2. Mathias Brodala commented on patch set 1 03/29/16, 07:19

    In general +1 but maybe add an Important RST for the case people where somehow relying on the previous priorities. E.g. when extending an existing type converter but changing source/target types.
  3. Christian Kuhn commented on patch set 1 03/31/16, 20:26

    Yes, an [!!!] and important.rst is needed, I'd say. Also, I'd refrain from a 7.6 backport since this may break existing extensions that may rely on current numbers and may lead to nasty+hard to find issues in patch level releases.
  4. TYPO3com voted on patch set 1 V -1 12/04/16, 11:38 Completed build in 37m 51s on Sun, 4 Dec, 12:38 PM Test Summary: 48 of 54322 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5484

  5. Susi Moog uploaded patch set 2 12/07/16, 14:47

  6. Susi Moog updated the commit message in patch set 3 12/07/16, 14:49

  7. TYPO3com voted on patch set 2 V +1 12/07/16, 14:51 Completed build in 04m 29s on Wed, 7 Dec, 03:51 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5578

  8. TYPO3com voted on patch set 3 V +1 12/07/16, 14:54 Completed build in 05m 28s on Wed, 7 Dec, 03:54 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5579

  9. Wouter Wolters commented on patch set 3 CR +1 V +1 12/07/16, 14:55

    Looks good to me.
  10. Susi Moog voted on patch set 3 CR +2 V +2 12/07/16, 15:08

  11. Gerrit merged patch set 3 12/07/16, 15:08

  12. Helmut Hummel commented on patch set 4 12/08/16, 00:39

    post -1 This change breaks the \TYPO3\CMS\Form\Mvc\Property\TypeConverter\UploadedFileReferenceConverter which has priority 2 but must take precedence over the \TYPO3\CMS\Extbase\Property\TypeConverter\FileReferenceConverter, which now as priority 10