Review main Merged Breaking

47368[!!!][BUGFIX] Remove ce-bodytext element if not needed

Jan Fässler CR +2 V +2 Normal +48 −7 updated 04/13/16, 08:04

Commit message

The wrapping div is superfluous if neither text nor header is set in
fluid_styled_content

Review

  • Code review CR +2
    • Susi Moog +2
    • Jan Helke +1
  • Verified V +2
    • Susi Moog +2
    • Jan Helke +1

Issues 1

Files 2

Review log 14

  1. Jan Fässler uploaded patch set 1 03/23/16, 14:02

  2. Jan Helke voted on patch set 1 CR +1 V +1 04/10/16, 07:42

  3. Jan Helke updated the commit message in patch set 2 04/10/16, 07:47

  4. Jan Helke voted on patch set 2 CR +1 V +1 04/10/16, 07:48

  5. Susi Moog commented on patch set 2 CR -1 04/10/16, 07:56

    not for 7.6, please add a breaking RST.
  6. Jan Helke voted on patch set 2 CR 0 V 0 04/10/16, 07:57

  7. Jan Helke commented on patch set 2 04/10/16, 12:25

    I agree with Susi. We need for sure a breaking RST and should avoid backporting that to 7.6. Because a lot of installations out there will get in trouble, if they relied there CSS on that particular ce-bodytext.
  8. Jan Helke uploaded patch set 3 04/12/16, 13:10

  9. Jan Helke voted on patch set 3 CR +1 V +1 04/12/16, 13:15

  10. Jan Helke commented on patch set 3 04/12/16, 13:18

    I removed the 7.6 release flag, because that could do a lot of harm in live systems, that rely on ce-bodytext. If you dearly in need for this feature in a 7.6 system, please use a custom template.
  11. Andreas Kienast updated the commit message in patch set 4 04/12/16, 13:31

  12. Jan Helke voted on patch set 4 CR +1 V +1 04/12/16, 13:42

  13. Susi Moog voted on patch set 4 CR +2 V +2 04/13/16, 08:04

  14. Gerrit merged patch set 4 04/13/16, 08:04