Review main Merged

47376[BUGFIX] target to page object must set type parameter

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 03/31/16, 08:25

Commit message

Setting typolink.target to the name of a page object must set the
type query parameter to the typeNum of that page object. By initializing
$theTypeP to an empty string the type is not forced to zero.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1

Issues 1

Files 1

Review log 8

  1. Jigal van Hemert uploaded patch set 1 03/23/16, 21:31

  2. Benni Mack voted on patch set 1 CR +1 03/29/16, 05:30

  3. Benni Mack voted on patch set 1 V +1 03/30/16, 17:47

  4. Benni Mack commented on patch set 1 03/30/16, 17:48

    My test scenario page = PAGE page.2 = TEXT page.2.value = This links on page type 212 page.2.typolink.parameter = 1 page.2.typolink.target = bennipage bennipage = PAGE bennipage.typeNum = 212 bennipage.10 = TEXT bennipage.10.value = This is a page with type 212
  5. Oliver Hader voted on patch set 1 CR +1 03/30/16, 20:32

  6. Susi Moog voted on patch set 1 CR +2 V +2 03/31/16, 08:24

  7. Gerrit merged patch set 1 03/31/16, 08:25

  8. Susi Moog commented on patch set 2 03/31/16, 08:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 52e57f24a3eca1bd91444b359faa062a03e61d01