47378[!!!][TASK] Remove entryPointPath from main applications
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
Issues 1
Files 10
- typo3/sysext/backend/Classes/Console/Application.php+4 −4
- typo3/sysext/backend/Classes/Http/Application.php+6 −4
- typo3/sysext/core/Classes/Console/CommandApplication.php+4 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php+10 −6
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+23 −23
- typo3/sysext/core/Documentation/Changelog/master/Breaking-75323-RemovedParameterEntryPointPathFromMainApplications.rstnew+33 −0
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+3 −3
- typo3/sysext/core/Tests/Testbase.php+1 −1
- typo3/sysext/frontend/Classes/Http/Application.php+6 −5
- typo3/sysext/install/Classes/Http/Application.php+4 −3
Review log 18
-
Benni Mack uploaded patch set 1 03/24/16, 06:28
-
Christian Kuhn commented on patch set 1 CR -1 03/24/16, 10:51
will be solved differently by benni. -
Benni Mack uploaded patch set 2 03/29/16, 13:27
-
Benni Mack updated the commit message in patch set 3 03/30/16, 17:43
-
Benni Mack commented on patch set 3 03/30/16, 17:43
I don't know if I consider this a breaking change, since it really touches only internal API? -
Oliver Hader commented on patch set 3 V -1 03/30/16, 21:13
Looks good, however fails if not configuration is available (PoC: rename or remove typo3conf/LocalConfiguration.php). Besides that, my gut feeling says, it's a breaking change since SystemEnvironmentBuilder and Bootstrap could have been used by other (specific) 3rd party components -
Benni Mack uploaded patch set 4 03/31/16, 07:00
-
Christian Kuhn voted on patch set 4 CR +1 03/31/16, 14:27
-
Christian Kuhn commented on patch set 4 V -1 03/31/16, 14:30
unit test failure: 1) TYPO3\CMS\Core\Tests\Unit\Core\SystemEnvironmentBuilderTest::getUnifiedDirectoryNameWithTrailingSlashReturnsCorrectPathOnUnix call_user_func_array() expects parameter 1 to be a valid callback, class 'Mock_Tx_Phpunit_AccessibleProxy66261833256fd3427503da592027197_b0fa85c5' does not have a method 'getUnifiedDirectoryNameWithTrailingSlash' -
Benni Mack uploaded patch set 5 03/31/16, 15:34
-
Christian Kuhn commented on patch set 5 03/31/16, 16:02
... ok, let's add a breaking.rst file. at least that could help to hint for this change. keeping b/w compat isn't easily possible since we're unable to deprecate the old way with a deprecation log at this point in bootstrap. -
Benni Mack uploaded patch set 6 03/31/16, 16:14
-
Christian Kuhn uploaded patch set 7 03/31/16, 16:35
-
Christian Kuhn voted on patch set 7 CR +1 V +1 03/31/16, 16:40
-
Susi Moog voted on patch set 7 CR +1 V +1 03/31/16, 20:52
-
Christian Kuhn voted on patch set 7 CR +2 03/31/16, 21:01
-
Christian Kuhn voted on patch set 7 V +2 03/31/16, 21:01
-
Gerrit merged patch set 7 03/31/16, 21:01