Review main Merged Breaking

47378[!!!][TASK] Remove entryPointPath from main applications

Benni Mack CR +2 V +2 Normal +94 −52 updated 03/31/16, 21:01

Commit message

The entry point path is only used to calculate the number
of levels nested under the PATH_site so the PATH_site
constant can be calculated.

In order to be more flexible with paths, the hard-coded name
"typo3/" is removed and the calculation is based on the
number of subdirectories instead of naming the directories
which are irrelevant.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 10

Review log 18

  1. Benni Mack uploaded patch set 1 03/24/16, 06:28

  2. Christian Kuhn commented on patch set 1 CR -1 03/24/16, 10:51

    will be solved differently by benni.
  3. Benni Mack uploaded patch set 2 03/29/16, 13:27

  4. Benni Mack updated the commit message in patch set 3 03/30/16, 17:43

  5. Benni Mack commented on patch set 3 03/30/16, 17:43

    I don't know if I consider this a breaking change, since it really touches only internal API?
  6. Oliver Hader commented on patch set 3 V -1 03/30/16, 21:13

    Looks good, however fails if not configuration is available (PoC: rename or remove typo3conf/LocalConfiguration.php). Besides that, my gut feeling says, it's a breaking change since SystemEnvironmentBuilder and Bootstrap could have been used by other (specific) 3rd party components
  7. Benni Mack uploaded patch set 4 03/31/16, 07:00

  8. Christian Kuhn voted on patch set 4 CR +1 03/31/16, 14:27

  9. Christian Kuhn commented on patch set 4 V -1 03/31/16, 14:30

    unit test failure: 1) TYPO3\CMS\Core\Tests\Unit\Core\SystemEnvironmentBuilderTest::getUnifiedDirectoryNameWithTrailingSlashReturnsCorrectPathOnUnix call_user_func_array() expects parameter 1 to be a valid callback, class 'Mock_Tx_Phpunit_AccessibleProxy66261833256fd3427503da592027197_b0fa85c5' does not have a method 'getUnifiedDirectoryNameWithTrailingSlash'
  10. Benni Mack uploaded patch set 5 03/31/16, 15:34

  11. Christian Kuhn commented on patch set 5 03/31/16, 16:02

    ... ok, let's add a breaking.rst file. at least that could help to hint for this change. keeping b/w compat isn't easily possible since we're unable to deprecate the old way with a deprecation log at this point in bootstrap.
  12. Benni Mack uploaded patch set 6 03/31/16, 16:14

  13. Christian Kuhn uploaded patch set 7 03/31/16, 16:35

  14. Christian Kuhn voted on patch set 7 CR +1 V +1 03/31/16, 16:40

  15. Susi Moog voted on patch set 7 CR +1 V +1 03/31/16, 20:52

  16. Christian Kuhn voted on patch set 7 CR +2 03/31/16, 21:01

  17. Christian Kuhn voted on patch set 7 V +2 03/31/16, 21:01

  18. Gerrit merged patch set 7 03/31/16, 21:01