Review main Merged

47388[TASK] Upgrade to phpunit 5.2

Christian Kuhn CR +2 V +2 Hard +271 −184 updated 03/24/16, 19:43

Commit message

With minimum php7 and after codeception released a patch level
that introduced phpunit 5.x support, we can upgrade our phpunit
dev dependency to 5.2 along with a patch level upgrade of vfsStream.

This phpunit version is a bit more strict, some unclean tests
stumble and need fixes:

* $this->setExpectedException() needs a string as second argument,
all places with $this->anything() or $this->any() to ignore the
actual exception string are now substituted with empty string, the
tests rely on the timestamp to specify a specific exception.

* $aMock->expects()->method('aMethod') now throws exceptions if a
method name is specified that is either not mocked in $this->getMock()
or that does not exist in the mocked class. This was previously
ignored. This change now catches a lot of code smell in our tests :)

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 45

Show 25 more files

Review log 7

  1. Christian Kuhn uploaded patch set 1 03/24/16, 16:27

  2. Christian Kuhn uploaded patch set 2 03/24/16, 18:37

  3. Christian Kuhn uploaded patch set 3 03/24/16, 18:56

  4. Christian Kuhn commented on patch set 3 03/24/16, 19:16

  5. Anja Leichsenring voted on patch set 3 CR +1 V +1 03/24/16, 19:20

  6. Wouter Wolters voted on patch set 3 CR +2 V +2 03/24/16, 19:43

  7. Gerrit merged patch set 3 03/24/16, 19:43