47393[TASK] Increase test coverage of DatabaseConnection classes
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Christian Kuhn +2
- Tymoteusz Motylewski +1
Issues 1
Files 4
- typo3/sysext/core/Tests/Functional/Database/DatabaseConnectionTest.php8new+759 −0
- typo3/sysext/core/Tests/Functional/Database/PreparedStatementTest.php6new+102 −0
- typo3/sysext/core/Tests/Unit/Database/DatabaseConnectionTest.php2+511 −175
- typo3/sysext/core/Tests/Unit/Database/PreparedStatementTest.php+107 −33
Review log 12
-
Morton Jonuschat uploaded patch set 1 03/25/16, 20:55
-
Wouter Wolters commented on patch set 1 03/26/16, 09:19
DatabaseConnectionTest.php:69protectedPreparedStatementTest.php:21preparedstatementPreparedStatementTest.php:50protectedPreparedStatementTest.php:69protectedDatabaseConnectionTest.php:52protected -
Morton Jonuschat uploaded patch set 2 03/26/16, 09:56
-
Morton Jonuschat commented on patch set 1 03/26/16, 09:57
DatabaseConnectionTest.php:50ReplyDoneDatabaseConnectionTest.php:69ReplyDonePreparedStatementTest.php:21ReplyDonePreparedStatementTest.php:50ReplyDonePreparedStatementTest.php:69ReplyDoneDatabaseConnectionTest.php:52ReplyDone -
Frank Nägler commented on patch set 2 03/29/16, 07:49
DatabaseConnectionTest.php:246should we test also the input: \var\log\syslog.log (single backslashes? maybe also for the other DataProvider -
Morton Jonuschat commented on patch set 2 03/29/16, 08:02
DatabaseConnectionTest.php:246ReplyThis is a single backslash, the string representation needs to escape the backslash to \\ to make sure it's the literal character, not some other escape sequence. Thats why we always wrote 'TYPO3\\CMS\\Core\\..." before the ::class Syntax -
Frank Nägler commented on patch set 2 03/29/16, 08:09
DatabaseConnectionTest.php:246Replyiirc your only need the double backslash if the string is quoted in double quotes, not in single quotes. e.g.: $string = 'abc\def'; OR $string = "abc\\def"; in this case, single quotes are used, a single backslash. -
Morton Jonuschat uploaded patch set 3 03/30/16, 15:50
-
Morton Jonuschat commented on patch set 2 03/30/16, 15:52
DatabaseConnectionTest.php:246ReplyThat usage is actually a fallback due to unsupported escape sequences and results in the same output as correctly escaping a literal backslash. Nevertheless I added a test case for that. -
Tymoteusz Motylewski voted on patch set 3 CR +1 V +1 03/30/16, 20:41
-
Christian Kuhn voted on patch set 3 CR +2 V +2 03/30/16, 20:42
-
Gerrit merged patch set 3 03/30/16, 20:42
DatabaseConnectionTest.php:50