Review main Merged

47395[BUGFIX] Fail with exit code for fatal errors during boot

Helmut Hummel CR +2 V +2 Easy +37 −8 updated 03/30/16, 17:44

Commit message

Especially for CI environments it is crucial that TYPO3
does not exit cleanly when a fatal error occurs.

Change from die (which exits with return code 0) to exit(1)
and send a http error code as well (in web requests)

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1

Issues 1

Files 2

Review log 11

  1. Helmut Hummel uploaded patch set 1 03/27/16, 19:39

  2. Helmut Hummel uploaded patch set 2 03/27/16, 19:48

  3. Anja Leichsenring voted on patch set 2 CR +1 V +1 03/27/16, 19:54

  4. Mathias Schreiber voted on patch set 2 CR +1 V +1 03/27/16, 20:35

  5. Andreas Kienast voted on patch set 2 CR +1 03/28/16, 16:07

  6. Wouter Wolters voted on patch set 2 CR +1 03/29/16, 06:41

  7. Benni Mack voted on patch set 2 CR +2 V +2 03/30/16, 12:50

  8. Helmut Hummel voted on patch set 2 CR +2 V +2 03/30/16, 12:52

  9. Gerrit merged patch set 2 03/30/16, 12:52

  10. Christian Kuhn commented on patch set 3 03/30/16, 17:27

    Testbase.php:703

    the header stuff isn't needed. unit, functionals and acceptance can only be called in cli context. will re-check and send a follow-up.
  11. Christian Kuhn commented on patch set 3 03/30/16, 17:44