Review main Merged

47413[BUGFIX] Allow languages with more than 2 chars for BE users

Morton Jonuschat CR +2 V +2 Easy +1 −1 updated 03/30/16, 08:10

Commit message

Allow up to 6 characters for the lang column in the be_users table to
support languages like Brazilian (pt_BR) or French/Canada (fr_CA).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Xavier Perseguers +1
  • Verified V +2
    • Christian Kuhn +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 8

  1. Morton Jonuschat uploaded patch set 1 03/30/16, 07:37

  2. Andreas Kienast commented on patch set 1 03/30/16, 07:40

    Should we change this to varchar, then?
  3. Xavier Perseguers commented on patch set 1 CR -1 03/30/16, 07:57

    yes andreas, just told Morton as well :)
  4. Morton Jonuschat commented on patch set 1 03/30/16, 07:57

    Done
  5. Morton Jonuschat uploaded patch set 3 03/30/16, 07:58

  6. Xavier Perseguers voted on patch set 3 CR +1 V +1 03/30/16, 08:02

  7. Christian Kuhn voted on patch set 3 CR +2 V +2 03/30/16, 08:10

  8. Gerrit merged patch set 3 03/30/16, 08:10