47419[BUGFIX] Skip two unit tests with symlinks on Windows
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 13
-
Jigal van Hemert uploaded patch set 1 03/30/16, 09:21
-
Susi Moog commented on patch set 1 03/30/16, 09:33
Why do you want to skip them? They are running fine on my windows 10. -
Stephan Großberndt commented on patch set 1 03/30/16, 10:41
you have to run them with administrative rights. I see no reason to skip them too -
Richard Haeser voted on patch set 1 CR +1 03/30/16, 11:07
-
Susi Moog commented on patch set 1 CR -1 03/30/16, 11:42
as said, they are running fine (with admin rights) -
Stephan Großberndt voted on patch set 1 CR -1 03/30/16, 12:05
-
Nicole Hummel commented on patch set 1 CR -2 03/30/16, 18:34
Please do not skip more tests on Windows if not necessary. We should try to improve tests to even run on Windows systems! -
Oliver Hader commented on patch set 1 03/30/16, 19:57
I think this one can be abandoned, right? -
Jigal van Hemert commented on patch set 1 03/30/16, 20:13
> Please do not skip more tests on Windows if not necessary. We > should try to improve tests to even run on Windows systems! More than a dozen other tests with symlink function are also skipped. Like these two they also fail on Windows, even with a user that is a member of the Administrator group (which is not recommended for Win10). If someone knows how to make them work, please change it, until then they are just failing on windows and should be skipped IMO. -
Nicole Hummel commented on patch set 1 03/30/16, 21:01
> More than a dozen other tests with symlink function are also skipped Can you give some examples, please. Maybe they are skipped for another reason than symlinks? -
Jigal van Hemert commented on patch set 1 03/31/16, 15:15
> Can you give some examples, please. Maybe they are skipped for > another reason than symlinks? Search for "Test not available on Windows OS" and you'll see quite a few tests with symlink() in them. Removing the check for TYPO3_OS === 'WIN' makes the fail on the symlink() call. -
Susi Moog commented on patch set 1 04/01/16, 12:41
yes, there are skipped tests with symlinks on windows, but: - for some of them skipping is not necessary, because they actually run on modern windows - for some of them, they are skipped as they assume paths starting with / I will go through them on the weekend and push a patch where I remove the skipping (@Nicole if you have time it would be cool if you could run them on win7 then). -
Mathias Schreiber abandoned the change 04/09/16, 20:31
Susi will take care during UXW